54 lines
1.9 KiB
Diff
54 lines
1.9 KiB
Diff
From de4666781c5a64cd55aa6688f77de95f8f66b2c0 Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Linus=20L=C3=BCssing?= <linus.luessing@c0d3.blue>
|
|
Date: Fri, 3 Jul 2015 18:29:56 +0200
|
|
Subject: [PATCH 14/17] batman-adv: Fix broken DAT capability check
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
The introduction of set_bit() and clear_bit() calls in batman-adv
|
|
wrongly passed bitmasks and not the bit numbers to these functions.
|
|
This leads to broken capability checks.
|
|
|
|
Fixing this by making the capability enum a non-bitmasked one and by
|
|
that passing non-masked values to set_bit()/clear_bit().
|
|
|
|
Fixes: bfd0fbaef270 ("batman-adv: Make DAT capability changes atomic")
|
|
Reported-by: Def <def@laposte.net>
|
|
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
|
|
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
|
|
---
|
|
distributed-arp-table.c | 2 +-
|
|
types.h | 2 +-
|
|
2 files changed, 2 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/distributed-arp-table.c b/distributed-arp-table.c
|
|
index b2cc19b..c0c514d 100644
|
|
--- a/distributed-arp-table.c
|
|
+++ b/distributed-arp-table.c
|
|
@@ -422,7 +422,7 @@ static bool batadv_is_orig_node_eligible(struct batadv_dat_candidate *res,
|
|
int j;
|
|
|
|
/* check if orig node candidate is running DAT */
|
|
- if (!(candidate->capabilities & BATADV_ORIG_CAPA_HAS_DAT))
|
|
+ if (!(test_bit(BATADV_ORIG_CAPA_HAS_DAT, &candidate->capabilities)))
|
|
goto out;
|
|
|
|
/* Check if this node has already been selected... */
|
|
diff --git a/types.h b/types.h
|
|
index 65dc6bf..08a6343 100644
|
|
--- a/types.h
|
|
+++ b/types.h
|
|
@@ -299,7 +299,7 @@ struct batadv_orig_node {
|
|
* (= orig node announces a tvlv of type BATADV_TVLV_MCAST)
|
|
*/
|
|
enum batadv_orig_capabilities {
|
|
- BATADV_ORIG_CAPA_HAS_DAT = BIT(0),
|
|
+ BATADV_ORIG_CAPA_HAS_DAT,
|
|
BATADV_ORIG_CAPA_HAS_NC = BIT(1),
|
|
BATADV_ORIG_CAPA_HAS_TT = BIT(2),
|
|
BATADV_ORIG_CAPA_HAS_MCAST = BIT(3),
|
|
--
|
|
2.1.4
|
|
|