Commit Graph

16 Commits

Author SHA1 Message Date
Hannu Nyman b8d0049e7c irqbalance: update to version 1.9.4
Update irqbalance to version 1.9.4.

* refresh version in meson patch
* remove EINVAL handling patch as upstream seems to have silenced
  the log spam for unmanageable IRQs

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2024-03-24 23:23:16 +02:00
Hannu Nyman 78c4791f42 irqbalance: Fix log spam and correct meson version
Irqbalance 1.9.3 changed the handling of certain errors.
Specifically EINVAL, trying to set an invalid CPU core,
was changed to be a temporary error, causing log spam from
repeated balancing runs in some devices. See log and strace below.
Mark EINVAL as permanent.

Also correct the version in our own meson.build patch.

Log and strace:

Sat Dec  9 10:17:27 2023 daemon.warn irqbalance: Cannot change IRQ 48 affinity: Invalid argument

open("/proc/irq/48/smp_affinity", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = 6
mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0xb6ed9000
ioctl(6, TIOCGWINSZ, 0xbeb134e8)        = -1 ENOTTY (Not a tty)
writev(6, [{iov_base="00000001", iov_len=8}, {iov_base=NULL, iov_len=0}], 2) = -1 EINVAL (Invalid argument)
close(6)                                = 0
munmap(0xb6ed9000, 4096)                = 0
clock_gettime64(CLOCK_REALTIME, {tv_sec=1702109847, tv_nsec=340549081}) = 0
sendto(5, "<28>Dec  9 08:17:27 irqbalance: "..., 80, 0, NULL, 0) = 80
writev(1, [{iov_base="Cannot change IRQ 48 affinity: I"..., iov_len=47}, {iov_base="\n", iov_len=1}], 2Cannot change IRQ 48 affinity: Invalid argument
) = 48

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2023-12-09 12:13:27 +02:00
Hannu Nyman b8298a9b91 irqbalance: update to 1.9.3
Update irqbalance to version 1.9.3.
* remove upstreamed patch.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2023-11-12 22:42:44 +02:00
Hannu Nyman 22188b42bd irqbalance: Add upstream fix for AARCH64 irq name parsing
Add upstream fix for AARCH64 irq name parsing.

> On arm64 SoCs like TI's K3 SoC and few other SoCs,
> IRQ names don't get parsed correct due to which they
> end up being classified into wrong class. Fix this by
> considering last token to contain IRQ name always.

The fix seems to enable e.g. RT3200 to notice a few more
interrupts and start balancing them.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2023-02-15 23:51:58 +02:00
Hannu Nyman c1582e1ad0 irqbalance: update to 1.9.1
Update irqbalance version to 1.9.1

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2022-10-18 17:57:16 +03:00
Rosen Penev 59cadc7c65 irqbalance: add meson
Fixes compilation when libiconv is missing.

Also remove pthread from glibc. No longer needed.

Cleanup Makefile for consistency between packages.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-19 16:19:05 +03:00
Hannu Nyman ab7a23102e irqbalance: upstream patch to fix segfault
Apply post-1.9.0 patch from upstream to fix a segfault.
savedptr can be NULL, so guard for that.

Fixes #18741

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2022-06-12 20:26:02 +03:00
Hannu Nyman 358c2293fa irqbalance: upstream patch to fix irq-module relation
Apply post-1.9.0 patch from upstream to fix the irq-->module
relation detection.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2022-06-12 20:24:36 +03:00
Hannu Nyman 8e71e0ad97 irqbalance: remove local patch for socket directory
Upstream has finally patched the UI communication socket
creation to happen only if the irqbalance UI is enabled.

As we do not use the irqbalance UI, we can remove
our local fix implemented by 4f0c847828.
(If you want to enable irqbalance UI, the fix is still needed.)

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2022-06-04 14:12:28 +03:00
Hannu Nyman 6631cfaa61 irqbalance: upgrade to version 1.8.0
Upgrade irqbalance to version 1.8.0

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2021-04-18 18:26:43 +03:00
Hannu Nyman a32b41d3f0 irqbalance: update to 1.7.0
Update irqbalance to version 1.7.0
Refresh patches.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2020-08-11 23:45:20 +03:00
Hannu Nyman 4f0c847828 irqbalance: fix socket directory and create it
Irqbalance defines /run/irqbalance dir for its socket
communication between irqbalance and its UI. /run does not exist
in OpenWrt (although it is defined by the Linux FHS), so the
socket creation fails. Although we do not compile UI and thus
the issue is not critical to us, fix the directory location.

Additionally, the creation is originally handled by a systemd
init script that we do not use.

* patch source to define dir as /var/run/irqbalance
* create the dir in the procd init script.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2020-06-17 23:29:13 +03:00
Marc Benoit bdcb872a40 irqbalance: upgrade to 1.6.0
Upgraded from 1.2.0 to 1.6.0 to pick up
all the latest fixes and improvements

irqbalance made glib2 mandatory since 1.3.0, but is
using very little of it. glib2 linked statically
to minimize the impact.

1.2.0 size: 33,619
1.6.0 size: 99,539

~# irqbalance --version
	irqbalance version 1.6.0

~# ldd /usr/sbin/irqbalance
	/lib/ld-musl-armhf.so.1 (0xb6f5f000)
	libgcc_s.so.1 => /lib/libgcc_s.so.1 (0xb6f43000)
	libc.so => /lib/ld-musl-armhf.so.1 (0xb6f5f000)

~# opkg info irqbalance
	Package: irqbalance
	Version: 1.6.0-6
	Depends: libc
	Status: install user installed
	Architecture: arm_cortex-a7_neon-vfpv4
	Installed-Time: 1582839249

Compile-tested: ipq806x/R7800 & ipq40xx/GL-B1300
Run-tested:     ipq806x/R7800 & ipq40xx/GL-B1300

Signed-off-by: Marc Benoit <marcb62185@gmail.com>
2020-02-29 07:20:47 -05:00
Hannu Nyman 0cb6e15f01 irqbalance: fix AARCH64 compilation
AARCH64 compilation fails due to upstream bug in 1.2.0
that has been later fixed. Backport the fix commit.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2018-07-19 21:37:30 +03:00
Hannu Nyman c42ecd05a1 irqbalance: avoid external glib2
Revert an upstream commit to enable compiling without external glib2.

Edit the 'disable UI compilation' patch to match the original
upstream commit more closely.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2017-02-08 11:12:39 +02:00
Hannu Nyman c5913bd12d irqbalance: add package
The purpose of irqbalance is to distribute hardware interrupts across
processors/cores on a multiprocessor/-core system in order to increase
performance.

This initial implementation of the package uses external glib2,
which is a large dependency.
Only the cmd-line tool is compiled and installed.

Run-tested with ipq806x / R7800.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2017-02-08 00:26:58 +02:00