freifunk-franken
/
firmware
9
7
Fork 13
Code Issues 48 Pull Requests 7 Releases 17 Wiki Activity

Revert "fff-babeld: Add rule to lookup in fff table for everything except wireguard" #98

Closed
adschm wants to merge 1 commits from adschm:revertcd into master
pull from: adschm:revertcd
merge into: freifunk-franken:master
Conversation 2 Commits 1 Files Changed 2 +1 -6
adschm commented 2021-01-30 23:34:25 +01:00
Owner
Copy Link

This reverts commit 883b049ae5f0ce406bfee3edafebbf3943e23e5d.

With the patch there can be situations with just "*" in traceroute,
breaking MTU in wireguard. If R1 with IPv6 address from provider P1
is connected to Freifunk via wireguard, and another R2 with address
from provider P2 is behind it, then R1 won't answer to traceroutes
sent from R2.

Revert the patch for now.

Fixes: #66 (gitea)

Signed-off-by: Adrian Schmutzler freifunk@adrianschmutzler.de

This reverts commit 883b049ae5f0ce406bfee3edafebbf3943e23e5d. With the patch there can be situations with just "*" in traceroute, breaking MTU in wireguard. If R1 with IPv6 address from provider P1 is connected to Freifunk via wireguard, and another R2 with address from provider P2 is behind it, then R1 won't answer to traceroutes sent from R2. Revert the patch for now. Fixes: #66 (gitea) Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
adschm added the
bug
layer3
packages/fff
 labels 2021-01-30 23:34:25 +01:00
ChristianD commented 2021-01-30 23:37:02 +01:00
Member
Copy Link
Reviewed-by: Christian Dresel <freifunk@dresel.systems>
``` Reviewed-by: Christian Dresel <freifunk@dresel.systems> ```
adschm force-pushed revertcd from a887196322 to b87487ee92 2021-01-30 23:37:34 +01:00 Compare
fbl approved these changes 2021-01-30 23:38:11 +01:00
fbl left a comment
Owner
Copy Link

Reviewed-by: Fabian Bläse <fabian@blaese.de>

`Reviewed-by: Fabian Bläse <fabian@blaese.de>`
fbl added this to the 20210211-beta milestone 2021-01-30 23:39:12 +01:00
adschm commented 2021-01-31 14:06:02 +01:00
Author
Owner
Copy Link

Wird gleich gemergt.

Wird gleich gemergt.
adschm closed this pull request 2021-01-31 14:06:02 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
fbl
Labels
Clear labels   
RFC

   
RFT

   
WIP

   
blocked

   
bsp

touching bsp files or adding devices

  
bug

Something is not working

  
build/scripts/tools

touching buildscript or other tools

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
fixed

Issue that got resolved

  
layer3

only for layer3 FW

  
mantis

Imported from mantis

  
more details required

Reported information is insufficient to debug the issue

  
needs changes

   
node

only for node FW

  
packages/fff

touching our packages

  
rejected

Rejected or won't fix

  
security

   
trivial

simple non-functional changes that are mostly matter of taste

  
upstream

touching upstream version, build or feed patches

No Label
RFC
RFT
WIP
blocked
bsp
bug
build/scripts/tools
duplicate
feature
fixed
layer3
mantis
more details required
needs changes
node
packages/fff
rejected
security
trivial
upstream
Milestone
Clear milestone
No items
No Milestone
20210211-beta
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: freifunk-franken/firmware#98
No description provided.
Delete Branch "adschm:revertcd"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?