[RFC] packages/fff: introduce fff-defaults for selected packages #97

adschm · 2021-01-30T21:12:12+01:00

adschm commented

2021-01-30 21:12:12 +01:00

In principle, the uci-defaults files are meant for providing standard
values for a specific package. Our firmware is effectively abusing
this concept by using uci-defaults to set defaults for other
packages, e.g. fff-dhcp setting defaults for dnsmasq.

While this works relatively well for the current firmware, it
completely breaks apart if the packages are used as a feed for
vanilla OpenWrt.
Thus, in preparation for making the packages available for such a
scenario (read: "use packages as packages"), this moves all custom
defaults we set for other packages to a directory "fff-defaults".
If the firmware is built with buildscript (and sets the new
FFF_VARIANT variable), this is copied back to uci-defaults as usual.
But without that script, we now have "our" config in a dedicated
directory where we can use it otherwise as well.

This depends on my previous PR #96 that introduced FFF_VARIANT.

In principle, the uci-defaults files are meant for providing standard values for a specific package. Our firmware is effectively abusing this concept by using uci-defaults to set defaults for _other_ packages, e.g. fff-dhcp setting defaults for dnsmasq. While this works relatively well for the current firmware, it completely breaks apart if the packages are used as a feed for vanilla OpenWrt. Thus, in preparation for making the packages available for such a scenario (read: "use packages as packages"), this moves all custom defaults we set for other packages to a directory "fff-defaults". If the firmware is built with buildscript (and sets the new FFF_VARIANT variable), this is copied back to uci-defaults as usual. But without that script, we now have "our" config in a dedicated directory where we can use it otherwise as well. --- This depends on my previous PR #96 that introduced FFF_VARIANT.

adschm added the

layer3

packages/fff

build/scripts/tools

labels 2021-01-30 21:12:12 +01:00

adschm added 1 commit 2021-01-30 21:12:13 +01:00

526b290103 packages/fff: introduce fff-defaults for selected packages

In principle, the uci-defaults files are meant for providing standard
values for a specific package. Our firmware is effectively abusing
this concept by using uci-defaults to set defaults for _other_
packages, e.g. fff-dhcp setting defaults for dnsmasq.

While this works relatively well for the current firmware, it
completely breaks apart if the packages are used as a feed for
vanilla OpenWrt.
Thus, in preparation for making the packages available for such a
scenario (read: "use packages as packages"), this moves all custom
defaults we set for other packages to a directory "fff-defaults".
If the firmware is built with buildscript (and sets the new
FFF_VARIANT variable), this is copied back to uci-defaults as usual.
But without that script, we now have "our" config in a dedicated
directory where we can use it otherwise as well.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>

adschm added the

RFC

label 2021-01-30 21:12:23 +01:00

adschm changed title from ~~packages/fff: introduce fff-defaults for selected packages~~ to [RFC] packages/fff: introduce fff-defaults for selected packages

2021-01-30 21:12:29 +01:00

adschm closed this pull request

2021-08-24 02:08:42 +02:00