freifunk-franken
/
firmware
9
7
Fork 13
Code Issues 48 Pull Requests 7 Releases 17 Wiki Activity

fff-firewall: Restart when network configuration changes #92

Closed
fbl wants to merge 2 commits from fbl/firmware:firewall into master
pull from: fbl/firmware:firewall
merge into: freifunk-franken:master
Conversation 1 Commits 2 Files Changed 2 +2 -5
fbl commented 2021-01-27 16:51:27 +01:00
Owner
Copy Link

The configuration of our firewall depends on the network configuration.
Most importantly, the firewall has to be restarted, if the WAN-interface
is changed.

Therefore, a procd reload trigger is added to the init-script, so our
firewall is automatically restarted, when the network configuration is
changed.

Additionally, a few unused variables are removed.

This is a stripped-down version of #91.

Fixes: #46

The configuration of our firewall depends on the network configuration. Most importantly, the firewall has to be restarted, if the WAN-interface is changed. Therefore, a procd reload trigger is added to the init-script, so our firewall is automatically restarted, when the network configuration is changed. Additionally, a few unused variables are removed. This is a stripped-down version of #91. Fixes: #46
fbl added this to the 20210211-beta milestone 2021-01-27 16:51:27 +01:00
fbl added the
bug
 label 2021-01-27 16:51:27 +01:00
fbl added 2 commits 2021-01-27 16:51:27 +01:00
df87fc3851 fff-firewall: Restart when network configuration changes 
The configuration of our firewall depends on the network configuration.
Most importantly, the firewall has to be restarted, if the WAN-interface
is changed.

Therefore, a procd reload trigger is added to the init-script, so our
firewall is automatically restarted, when the network configuration is
changed.

Fixes: #46
Signed-off-by: Robert Langhammer <rlanghammer@web.de>
[fabian@blaese.de: Remove unrelated changes]
Signed-off-by: Fabian Bläse <fabian@blaese.de>
a4e8da8e99 fff-firewall: Remove variables not used by procd 
The Variables SERVICE_WRITE_PID and SERVICE_DAEMONIZE are not used by
procd, so they are removed.

Signed-off-by: Fabian Bläse <fabian@blaese.de>
rohammer approved these changes 2021-01-27 16:55:25 +01:00
rohammer left a comment
Member
Copy Link
Reviewed-by: Robert Langhammer <rlanghammer@web.de>
``` Reviewed-by: Robert Langhammer <rlanghammer@web.de> ```
adschm added the
packages/fff
 label 2021-01-27 19:05:43 +01:00
adschm commented 2021-01-27 19:38:40 +01:00
Owner
Copy Link

Danke, wird später gemergt.

Danke, wird später gemergt.
adschm closed this pull request 2021-01-27 19:38:40 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
rohammer
Labels
Clear labels   
RFC

   
RFT

   
WIP

   
blocked

   
bsp

touching bsp files or adding devices

  
bug

Something is not working

  
build/scripts/tools

touching buildscript or other tools

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
fixed

Issue that got resolved

  
layer3

only for layer3 FW

  
mantis

Imported from mantis

  
more details required

Reported information is insufficient to debug the issue

  
needs changes

   
node

only for node FW

  
packages/fff

touching our packages

  
rejected

Rejected or won't fix

  
security

   
trivial

simple non-functional changes that are mostly matter of taste

  
upstream

touching upstream version, build or feed patches

No Label
RFC
RFT
WIP
blocked
bsp
bug
build/scripts/tools
duplicate
feature
fixed
layer3
mantis
more details required
needs changes
node
packages/fff
rejected
security
trivial
upstream
Milestone
Clear milestone
No items
No Milestone
20210211-beta
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: freifunk-franken/firmware#92
No description provided.
Delete Branch "fbl/firmware:firewall"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?