fff-hoods: Allow correct ula_prefix syntax in hoodfiles #90
No reviewers
Labels
No Label
RFC
RFT
WIP
blocked
bsp
bug
build/scripts/tools
duplicate
feature
fixed
layer3
mantis
more details required
needs changes
node
packages/fff
rejected
security
trivial
upstream
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: freifunk-franken/firmware#90
Loading…
Reference in New Issue
No description provided.
Delete Branch "fbl:syntaxfix2"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
In earlier firmware versions the prefix had to be written
in an incorrect syntax (missing a trailing colon).
To make hoodfiles with this old incorrect syntax work with
newer firmware versions like this one, we have to fix the
incorrect syntax. Both the old, incorrect and the correct
syntax work with this fix, so in the far away future, the
correct syntax can be used in hoodfiles.
This is based on and thus requires: #77
Changes:
24ce581ca5
to738cab0796
@ -198,0 +198,4 @@
# newer firmware versions like this one, we have to fix the
# incorrect syntax here. Both the old, incorrect and
# the correct syntax work with this fix.
prefix="$(echo "$prefix" | sed -e 's,\([^:]\):\/,\1::/,')"
Der forward-slash muss nicht escaped werden (es funktioniert offenbar mit und ohne backslash zum escapen). Da nicht notwendig würde ich aber die Variante ohne Backslash vorziehen:
prefix=$(echo "$prefix" | sed -e 's,\([^:]\):/,\1::/,')
Die äußeren Anführungszeichen können ebenfalls entfallen, die Funktion gibt es bei a=$() für umsonst.
Mit dem entfernten Backslash
Reviewed-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
738cab0796
to0a66c2be1c
Changes:
Wird gleich gemergt.
Pull request closed