freifunk-franken
/
firmware
9
7
Fork 13
Code Issues 48 Pull Requests 7 Releases 17 Wiki Activity

fff-layer3-config: fix exit status of uci-default scripts #323

Closed
fbl wants to merge 1 commits from fbl/firmware:clear-uci-defaults into master
pull from: fbl/firmware:clear-uci-defaults
merge into: freifunk-franken:master
Conversation 2 Commits 1 Files Changed 2 +6 -2
fbl commented 2024-03-17 22:04:28 +01:00
Owner
Copy Link

OpenWrt only removes uci-defaults scripts if the exit status of the
executed script is 0. Fix the exit code of the layer3-config migration
scripts so they are removed as intended.

Fixes: #313

OpenWrt only removes uci-defaults scripts if the exit status of the executed script is 0. Fix the exit code of the layer3-config migration scripts so they are removed as intended. Fixes: #313
fbl added this to the 20240401-beta milestone 2024-03-17 22:04:28 +01:00
fbl added 1 commit 2024-03-17 22:04:29 +01:00
c56f090c78 fff-layer3-config: fix exit status of uci-default scripts 
OpenWrt only removes uci-defaults scripts if the exit status of the
executed script is 0. Fix the exit code of the layer3-config migration
scripts so they are removed as intended.

Fixes: #313

Signed-off-by: Fabian Bläse <fabian@blaese.de>
fbl force-pushed clear-uci-defaults from c56f090c78 to dbdd250289 2024-03-21 21:54:34 +01:00 Compare
fbl commented 2024-03-21 21:55:26 +01:00
Author
Owner
Copy Link

Changes:

  • Also use correct exit code when exiting prematurely, if no migration is necessary
Changes: - Also use correct exit code when exiting prematurely, if no migration is necessary
fbl commented 2024-03-21 21:57:06 +01:00
Author
Owner
Copy Link

Applied.

Applied.
fbl closed this pull request 2024-03-21 21:57:06 +01:00
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline is pending
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
RFC

   
RFT

   
WIP

   
blocked

   
bsp

touching bsp files or adding devices

  
bug

Something is not working

  
build/scripts/tools

touching buildscript or other tools

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
fixed

Issue that got resolved

  
layer3

only for layer3 FW

  
mantis

Imported from mantis

  
more details required

Reported information is insufficient to debug the issue

  
needs changes

   
node

only for node FW

  
packages/fff

touching our packages

  
rejected

Rejected or won't fix

  
security

   
trivial

simple non-functional changes that are mostly matter of taste

  
upstream

touching upstream version, build or feed patches

No Label
RFC
RFT
WIP
blocked
bsp
bug
build/scripts/tools
duplicate
feature
fixed
layer3
mantis
more details required
needs changes
node
packages/fff
rejected
security
trivial
upstream
Milestone
Clear milestone
No items
No Milestone
20240401-beta
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: freifunk-franken/firmware#323
No description provided.
Delete Branch "fbl/firmware:clear-uci-defaults"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?