fff-layer3-config: Always clear client interface list completely #210

fbl · 2022-02-27T01:36:35+01:00

fbl commented

2022-02-27 01:36:35 +01:00

Previously, some interfaces in the client ifname list have been kept.
The actual reason for this is unknown, it might have been used for the
bat0 interfaces.

Filtering the interface list in this way might lead to interfaces being
retained unintentionally, especially with the diverse naming of DSA
interfaces.

As it is not required anymore, remove the retention of some interfaces
completely.

Fixes: #207

Signed-off-by: Fabian Bläse fabian@blaese.de

Previously, some interfaces in the client ifname list have been kept. The actual reason for this is unknown, it might have been used for the bat0 interfaces. Filtering the interface list in this way might lead to interfaces being retained unintentionally, especially with the diverse naming of DSA interfaces. As it is not required anymore, remove the retention of some interfaces completely. Fixes: #207 Signed-off-by: Fabian Bläse <fabian@blaese.de>

fbl added this to the next-bugfix milestone 2022-02-27 01:36:35 +01:00

fbl added the

layer3

label 2022-02-27 01:36:35 +01:00

fbl self-assigned this 2022-02-27 01:36:35 +01:00

fbl added 1 commit 2022-02-27 01:36:36 +01:00

6a339bf295 fff-layer3-config: Always clear client interface list completely

Previously, some interfaces in the client ifname list have been kept.
The actual reason for this is unknown, it might have been used for the
bat0 interfaces.

Filtering the interface list in this way might lead to interfaces being
retained unintentionally, especially with the diverse naming of DSA
interfaces.

As it is not required anymore, remove the retention of some interfaces
completely.

Fixes: #207

Signed-off-by: Fabian Bläse <fabian@blaese.de>

rohammer approved these changes 2022-02-27 21:54:49 +01:00

rohammer left a comment

Reviewed-by: Robert Langhammer <rlanghammer@web.de>

``` Reviewed-by: Robert Langhammer <rlanghammer@web.de> ```

jkimmel commented

2022-03-03 15:39:02 +01:00

Reviewed-by: Johannes Kimmel <fff@bareminimum.eu>

`Reviewed-by: Johannes Kimmel <fff@bareminimum.eu>`

fbl modified the milestone from next-bugfix to 20220405-beta

2022-03-03 15:42:49 +01:00

fbl commented

2022-03-05 19:27:17 +01:00

Auf meinen staging tree applied.

fbl closed this pull request

2022-03-05 19:27:17 +01:00

fbl deleted branch ifret

2022-03-05 19:27:20 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

more details required

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: freifunk-franken/firmware#210