freifunk-franken
/
firmware
9
7
Fork 13
Code Issues 48 Pull Requests 7 Releases 17 Wiki Activity

packages/fff: remove unneeded Build/Prepare and Build/Configure #20

Closed
adschm wants to merge 1 commits from adschm:makefile into master
pull from: adschm:makefile
merge into: freifunk-franken:master
Conversation 1 Commits 1 Files Changed 27 +2 -206
adschm commented 2020-12-18 21:05:11 +01:00
Owner
Copy Link

Build/Prepare and Build/Configure are not required for packages
only contain local files and do not need any compilation.

Remove them.

Note that Build/Compile needs to be present and empty to overwrite
the defaults, though.

Build/Prepare and Build/Configure are not required for packages only contain local files and do not need any compilation. Remove them. Note that Build/Compile needs to be present and empty to overwrite the defaults, though.
adschm added the
packages/fff
 label 2020-12-18 21:05:11 +01:00
adschm added 1 commit 2020-12-18 21:05:11 +01:00
e3f9b770fb packages/fff: remove unneeded Build/Prepare and Build/Configure 
Build/Prepare and Build/Configure are not required for packages
only contain local files and do not need any compilation.

Remove them.

Note that Build/Compile needs to be present and empty to overwrite
the defaults, though.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
rohammer approved these changes 2020-12-22 00:41:13 +01:00
rohammer left a comment
Member
Copy Link

Ja, macht es doch etwas schlanker.

Reviewed-by: Robert Langhammer <rlanghammer@web.de>
Ja, macht es doch etwas schlanker. ``` Reviewed-by: Robert Langhammer <rlanghammer@web.de> ```
adschm commented 2020-12-22 13:48:05 +01:00
Author
Owner
Copy Link

Danke, wird gleich gemergt.

Danke, wird gleich gemergt.
adschm closed this pull request 2020-12-22 13:48:05 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
rohammer
Labels
Clear labels   
RFC

   
RFT

   
WIP

   
blocked

   
bsp

touching bsp files or adding devices

  
bug

Something is not working

  
build/scripts/tools

touching buildscript or other tools

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
fixed

Issue that got resolved

  
layer3

only for layer3 FW

  
mantis

Imported from mantis

  
more details required

Reported information is insufficient to debug the issue

  
needs changes

   
node

only for node FW

  
packages/fff

touching our packages

  
rejected

Rejected or won't fix

  
security

   
trivial

simple non-functional changes that are mostly matter of taste

  
upstream

touching upstream version, build or feed patches

No Label
RFC
RFT
WIP
blocked
bsp
bug
build/scripts/tools
duplicate
feature
fixed
layer3
mantis
more details required
needs changes
node
packages/fff
rejected
security
trivial
upstream
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: freifunk-franken/firmware#20
No description provided.
Delete Branch "adschm:makefile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?