freifunk-franken
/
firmware
9
7
Fork 13
Code Issues 48 Pull Requests 7 Releases 17 Wiki Activity

buildscript: Split removal of chipset and subtarget #192

Closed
fbl wants to merge 1 commits from fbl/firmware:er4-rename into master
pull from: fbl/firmware:er4-rename
merge into: freifunk-franken:master
Conversation 1 Commits 1 Files Changed 1 +2 -1
fbl commented 2021-12-27 14:42:22 +01:00
Owner
Copy Link

Some OpenWrt targets do not have subtargets. The filename only contains
the chipset in that case. Split the removal of chipset and subtarget
into multiple expressions, so the removal of the chipset works on
targets without subtargets as well.

Fixes: #187

Signed-off-by: Fabian Bläse fabian@blaese.de

Some OpenWrt targets do not have subtargets. The filename only contains the chipset in that case. Split the removal of chipset and subtarget into multiple expressions, so the removal of the chipset works on targets without subtargets as well. Fixes: #187 Signed-off-by: Fabian Bläse <fabian@blaese.de>
fbl added this to the 20220405-beta milestone 2021-12-27 14:42:22 +01:00
fbl added the
build/scripts/tools
 label 2021-12-27 14:42:22 +01:00
fbl added 1 commit 2021-12-27 14:42:22 +01:00
4d498215e2 buildscript: Split removal of chipset and subtarget 
Some OpenWrt targets do not have subtargets. The filename only contains
the chipset in that case. Split the removal of chipset and subtarget
into multiple expressions, so the removal of the chipset works on
targets without subtargets as well.

Fixes: #187

Signed-off-by: Fabian Bläse <fabian@blaese.de>
rohammer approved these changes 2021-12-28 21:40:57 +01:00
rohammer left a comment
Member
Copy Link
Reviewed-by: Robert Langhammer <rlanghammer@web.de>
``` Reviewed-by: Robert Langhammer <rlanghammer@web.de> ```
fbl commented 2021-12-30 16:03:23 +01:00
Author
Owner
Copy Link

Applied to my staging tree.

Applied to my staging tree.
fbl closed this pull request 2021-12-30 16:03:23 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
rohammer
Labels
Clear labels   
RFC

   
RFT

   
WIP

   
blocked

   
bsp

touching bsp files or adding devices

  
bug

Something is not working

  
build/scripts/tools

touching buildscript or other tools

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
fixed

Issue that got resolved

  
layer3

only for layer3 FW

  
mantis

Imported from mantis

  
more details required

Reported information is insufficient to debug the issue

  
needs changes

   
node

only for node FW

  
packages/fff

touching our packages

  
rejected

Rejected or won't fix

  
security

   
trivial

simple non-functional changes that are mostly matter of taste

  
upstream

touching upstream version, build or feed patches

No Label
RFC
RFT
WIP
blocked
bsp
bug
build/scripts/tools
duplicate
feature
fixed
layer3
mantis
more details required
needs changes
node
packages/fff
rejected
security
trivial
upstream
Milestone
Clear milestone
No items
No Milestone
20220405-beta
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: freifunk-franken/firmware#192
No description provided.
Delete Branch "fbl/firmware:er4-rename"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?