Retain old compat_version for sysupgrade compatibility #170

fbl · 2021-10-24T00:08:10+02:00

fbl commented

2021-10-24 00:08:10 +02:00

OpenWrt images contain a compat_version, which is used to block upgrades
to newer versions with incompatible configuration, if the configuration
cannot be migrated.

As we maintain our own configuration and all OpenWrt configuration files
are dropped on an upgrade, this upgrade block is not required.

To simplify the upgrade process, retain the old compat_version for the
next release and manually bump the compat_version after the upgrade, so
we stay compatible with future OpenWrt releases.

Signed-off-by: Fabian Bläse fabian@blaese.de

OpenWrt images contain a compat_version, which is used to block upgrades to newer versions with incompatible configuration, if the configuration cannot be migrated. As we maintain our own configuration and all OpenWrt configuration files are dropped on an upgrade, this upgrade block is not required. To simplify the upgrade process, retain the old compat_version for the next release and manually bump the compat_version after the upgrade, so we stay compatible with future OpenWrt releases. Signed-off-by: Fabian Bläse <fabian@blaese.de>

fbl added the

upstream

label 2021-10-24 00:08:10 +02:00

fbl force-pushed compatversion from 2db606d2ac to f6fe1ef747

2021-11-27 22:44:09 +01:00

Compare

fbl commented

2021-11-27 22:44:09 +01:00

Changes:

Split patch and manual bump into seperate commits, so they can be applied individually. This makes beta releases easier to test, as the version including the manual bump can't be skipped when upgrading to future releases.

Changes: - Split patch and manual bump into seperate commits, so they can be applied individually. This makes beta releases easier to test, as the version including the manual bump can't be skipped when upgrading to future releases.

rohammer commented

2021-11-27 23:53:54 +01:00

Hi,
das fuehlt sich irgendwie so aussen rum gebastelt an. Kann man den compat_version-check nicht komplett ausschalten?

Hi, das fuehlt sich irgendwie so aussen rum gebastelt an. Kann man den compat_version-check nicht komplett ausschalten?

fbl commented

2021-11-27 23:55:42 +01:00

Könnte man, aber nicht für vergangene Firmwares. Und an sich finde ich es gar nicht schlecht so einen Check verfügbar zu haben, deshalb wollte ich ihn eigentlich nicht deaktivieren.

Ich weiß, dass dieser Workaround etwas unschön ist. Um den Check so weit aufzubohren, dass wir unseren - aus OpenWrt Sicht - Spezialfall damit abbilden können, hatte ich bisher keine Zeit. :-(

Könnte man, aber nicht für vergangene Firmwares. Und an sich finde ich es gar nicht schlecht so einen Check verfügbar zu haben, deshalb wollte ich ihn eigentlich nicht deaktivieren. Ich weiß, dass dieser Workaround etwas unschön ist. Um den Check so weit aufzubohren, dass wir unseren - aus OpenWrt Sicht - Spezialfall damit abbilden können, hatte ich bisher keine Zeit. :-(

rohammer commented

2021-11-28 00:05:26 +01:00

Na ja, wir (du) muessen uns halt um den Workaround kuemmern, wenn es mit den versions weiter geht. Ist ja nicht wirklich hoch komplex.

Reviewed by: Robert Langhammer <rlanghammer@web.de>

Na ja, wir (du) muessen uns halt um den Workaround kuemmern, wenn es mit den versions weiter geht. Ist ja nicht wirklich hoch komplex. ``` Reviewed by: Robert Langhammer <rlanghammer@web.de> ```

fbl added this to the 20211201-beta milestone 2021-11-28 00:08:37 +01:00

fbl commented

2021-11-28 15:17:24 +01:00

Partially applied for a pre-release. The compat-version bump should be applied on release.

fbl modified the milestone from 20211201-beta to 20211220

2021-12-03 00:14:07 +01:00

fbl commented

2021-12-18 00:26:57 +01:00

For some unknown reason the compat_version is bumped to 1.1 with the current beta, despite having omitted the second patch to manually bump it.

Also, as support for a new mt7621 device has been added with the current beta/release, it might be desirable to limit this change to devices, which have been supported since the last release or earlier.

For some unknown reason the compat_version is bumped to 1.1 with the current beta, despite having omitted the second patch to manually bump it. Also, as support for a new mt7621 device has been added with the current beta/release, it might be desirable to limit this change to devices, which have been supported since the last release or earlier.

fbl commented

2021-12-20 18:01:46 +01:00

The compat_version is generated from board.json. The compat_version is written to that json here: https://github.com/openwrt/openwrt/blob/master/target/linux/ramips/mt7621/base-files/etc/board.d/05_compat-version

Therefore, the manual bump of the compat_version is not necessary, and the beta (sadly) already contains compat_version 1.1, so a force flash is required to get from the current beta to stable.

Upgrading from older stable versions to the next stable version is no problem though.

The compat_version is generated from board.json. The compat_version is written to that json here: https://github.com/openwrt/openwrt/blob/master/target/linux/ramips/mt7621/base-files/etc/board.d/05_compat-version Therefore, the manual bump of the compat_version is not necessary, and the beta (sadly) already contains compat_version 1.1, so a force flash is required to get from the current beta to stable. Upgrading from older stable versions to the next stable version is no problem though.

fbl closed this pull request

2021-12-20 18:01:46 +01:00

fbl deleted branch compatversion

2021-12-20 18:02:10 +01:00