fff-layer3-config: Disable SIGHUP during test mode #160

fbl · 2021-08-05T19:48:00+02:00

fbl commented

2021-08-05 19:48:00 +02:00

The SIGHUP signal is sent to a process if a hangup is detected on the
controlling terminal. This might happen if the ssh session, from which
the test mode was started, is disconnected.

Because ssh session disconnects might happen due to network
reconfiguration, aborting the test mode without restoring the old
settings might make the device unreachable.

Instead, disable the SIGHUP signal when test mode is activated, so
the script is either killed by the user (after successful configuration)
or the timer expires and the old settings are restored.

Fixes: #141

Signed-off-by: Fabian Bläse fabian@blaese.de

The SIGHUP signal is sent to a process if a hangup is detected on the controlling terminal. This might happen if the ssh session, from which the test mode was started, is disconnected. Because ssh session disconnects might happen due to network reconfiguration, aborting the test mode without restoring the old settings might make the device unreachable. Instead, disable the SIGHUP signal when test mode is activated, so the script is either killed by the user (after successful configuration) or the timer expires and the old settings are restored. Fixes: #141 Signed-off-by: Fabian Bläse <fabian@blaese.de>

fbl added 1 commit 2021-08-05 19:48:01 +02:00

bf7afe3ce9 fff-layer3-config: Disable SIGHUP during test mode

The SIGHUP signal is sent to a process if a hangup is detected on the
controlling terminal. This might happen if the ssh session, from which
the test mode was started, is disconnected.

Because ssh session disconnects might happen due to network
reconfiguration, aborting the test mode without restoring the old
settings might make the device unreachable.

Instead, disable the SIGHUP signal when test mode is activated, so
the script is either killed by the user (after successful configuration)
or the timer expires and the old settings are restored.

Fixes: #141

Signed-off-by: Fabian Bläse <fabian@blaese.de>

fbl added the

bug

layer3

labels 2021-08-05 19:48:08 +02:00

ChristianD commented

2021-08-07 10:11:08 +02:00

Reviewed-by: Christian Dresel <freifunk@dresel.systems>

`Reviewed-by: Christian Dresel <freifunk@dresel.systems>`

jkimmel commented

2021-08-11 16:50:26 +02:00

Reviewed-by: Johannes Kimmel <fff@bareminimum.eu>

`Reviewed-by: Johannes Kimmel <fff@bareminimum.eu>`