Remove unnecessary sysctls, add comments to the remaining ones. #139

Closed
fbl wants to merge 2 commits from fbl/firmware:sysctl-cleanup into master

2 Commits

Author SHA1 Message Date
Fabian Bläse 285c2cc22d fff-network: Add comments to set sysctls
To make it clear why the set sysctls are necessary, add appropriate
comments to them. Also reorder them for improved readability.

Signed-off-by: Fabian Bläse <fabian@blaese.de>
2021-04-19 19:02:39 +02:00
Fabian Bläse 9fc8413aec fff-network: Remove obsolete and unnecessary sysctls
Many of the set sysctls are either unnecessary, are already default in
the kernel or in OpenWrts defaults, or the reason for them being
explicitly set is unknown.

Remove all those sysctls from fff-network, as unfounded deviations from
default values will cause hard-to-debug problems in the future.

The original motivation for this patch is the netdev_max_backlog sysctl,
which was set to a very low value without any reason or comment.
This hurt forwarding performance on mt7621 with DSA significantly and
took quite a while to discover.

Signed-off-by: Fabian Bläse <fabian@blaese.de>
2021-04-19 19:02:27 +02:00