freifunk-franken
/
firmware
9
7
Fork 13
Code Issues 48 Pull Requests 7 Releases 17 Wiki Activity

tools: Fix buildscript-bash-completion #128

Closed
rohammer wants to merge 1 commits from rohammer:bash-compl into master
pull from: rohammer:bash-compl
merge into: freifunk-franken:master
Conversation 2 Commits 1 Files Changed 1 +1 -1
rohammer commented 2021-02-18 10:52:15 +01:00
Member
Copy Link

The dynamic completion of the variants is broken since 1946aaca87.
This hardcodes the available variants. They won't change often.

Signed-off-by: Robert Langhammer rlanghammer@web.de

The dynamic completion of the variants is broken since 1946aaca87. This hardcodes the available variants. They won't change often. Signed-off-by: Robert Langhammer <rlanghammer@web.de>
rohammer added 1 commit 2021-02-18 10:52:16 +01:00
8254dde36d
tools: Fix buildscript-bash-completion 
The dynamic completion of the variants is broken since 1946aaca87.
This hardcodes the available variants. They won't change often.

Signed-off-by: Robert Langhammer <rlanghammer@web.de>
adschm commented 2021-02-18 20:36:55 +01:00
Owner
Copy Link

Sorry, tools hatte ich überhaupt nicht auf dem Schirm.

Wahrscheinlich ist hardcoden hier tatsächlich das einfachste.
Aber warum hardcodest du hier und beim anderen "Tool" nicht?

Sorry, tools hatte ich überhaupt nicht auf dem Schirm. Wahrscheinlich ist hardcoden hier tatsächlich das einfachste. Aber warum hardcodest du hier und beim anderen "Tool" nicht?
adschm added the
bug
build/scripts/tools
 labels 2021-02-18 20:37:15 +01:00
adschm commented 2021-02-27 14:46:49 +01:00
Owner
Copy Link

Reviewed und meinem staging-Tree hinzugefügt:
https://git.freifunk-franken.de/adschm/firmware/commits/branch/staging

Reviewed und meinem staging-Tree hinzugefügt: https://git.freifunk-franken.de/adschm/firmware/commits/branch/staging
adschm closed this pull request 2021-02-27 14:46:49 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
RFC

   
RFT

   
WIP

   
blocked

   
bsp

touching bsp files or adding devices

  
bug

Something is not working

  
build/scripts/tools

touching buildscript or other tools

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
fixed

Issue that got resolved

  
layer3

only for layer3 FW

  
mantis

Imported from mantis

  
more details required

Reported information is insufficient to debug the issue

  
needs changes

   
node

only for node FW

  
packages/fff

touching our packages

  
rejected

Rejected or won't fix

  
security

   
trivial

simple non-functional changes that are mostly matter of taste

  
upstream

touching upstream version, build or feed patches

No Label
RFC
RFT
WIP
blocked
bsp
bug
build/scripts/tools
duplicate
feature
fixed
layer3
mantis
more details required
needs changes
node
packages/fff
rejected
security
trivial
upstream
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: freifunk-franken/firmware#128
No description provided.
Delete Branch "rohammer:bash-compl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?