WIP: Add fff-gre package #112

fbl · 2021-02-11T20:40:21+01:00

fbl commented

2021-02-11 20:40:21 +01:00

This package adds gateway.d scripts which create
peering interfaces using grev6.

Signed-off-by: Fabian Bläse fabian@blaese.de

This package adds gateway.d scripts which create peering interfaces using grev6. Signed-off-by: Fabian Bläse <fabian@blaese.de>

fbl added this to the next-feature milestone 2021-02-11 20:40:21 +01:00

fbl added the

feature

layer3

labels 2021-02-11 20:40:21 +01:00

fbl self-assigned this 2021-02-11 20:40:21 +01:00

fbl added 1 commit 2021-02-11 20:40:22 +01:00

6e5c1e82fc Add fff-gre package

This package adds gateway.d scripts which create
peering interfaces using grev6.

Signed-off-by: Fabian Bläse <fabian@blaese.de>

adschm reviewed 2021-02-11 23:12:26 +01:00

src/packages/fff/fff-gre/Makefile

						
				@ -0,0 +4,4 @@

				PKG_VERSION:=1

				PKG_RELEASE:=1

				PKG_BUILD_DIR:=$(BUILD_DIR)/fff-gre

adschm commented

2021-02-11 23:04:51 +01:00

PKG_VERSION, PKG_BUILD_DIR, Build/Prepare und Build/Configure kann weg.

src/packages/fff/fff-gre/Makefile

						
				@ -0,0 +16,4 @@

					DEPENDS:=+gre \

							 +@PACKAGE_grev4 \

							 +@PACKAGE_grev6 \

							 +fff-network

adschm commented

2021-02-11 23:06:28 +01:00

Maybe use the newer style (with tab indent only):

	DEPENDS:= \
		+gre \
		+@PACKAGE_grev4 \
		+@PACKAGE_grev6 \
		+fff-network

Maybe use the newer style (with tab indent only): ``` DEPENDS:= \ +gre \ +@PACKAGE_grev4 \ +@PACKAGE_grev6 \ +fff-network ```

src/packages/fff/fff-gre/files/etc/gateway.d/50-gre

						
				@ -0,0 +86,4 @@

						uci set network.${prefixname}_ip.ifname="@$prefixname"

						# add link local address

						uci add_list network.${prefixname}_ip.ip6addr="$(ipEUIAssemble "fe80::/64" "$ROUTERMAC")"

adschm commented

2021-02-11 23:11:01 +01:00

Two comments:

owipcalc needs to be used here
Reading the ROUTERMAC from the config is quite complicated here. We not just use either 'uci get network.client.macaddress' or 'cat /sys/class/net/br-client/address', which would make us fully independent of how we store that config here. (Ich werde da demnächst mal einen Patch schicken, um das auch bei babel/wg zu ändern.)

Two comments: 1. owipcalc needs to be used here 2. Reading the ROUTERMAC from the config is quite complicated here. We not just use either 'uci get network.client.macaddress' or 'cat /sys/class/net/br-client/address', which would make us fully independent of how we store that config here. (Ich werde da demnächst mal einen Patch schicken, um das auch bei babel/wg zu ändern.)

src/packages/fff/fff-gre/files/etc/gateway.d/50-gre

						
				@ -0,0 +93,4 @@

						babel_add_peer6addr "network.${prefixname}_ip.ip6addr"

						# add iif-rules

						babel_add_iifrules "$prefixname" || { echo "ERROR: Could not add iif-rules for gre6eer $name"; exit 1; }

adschm commented

2021-02-11 23:11:32 +01:00

Multiline wäre schöner:

babel_add_iifrules "$prefixname" || {
	echo "ERROR: Could not add iif-rules for gre6eer $name";
    exit 1;
    }

Multiline wäre schöner: ``` babel_add_iifrules "$prefixname" || { echo "ERROR: Could not add iif-rules for gre6eer $name"; exit 1; } ```

src/packages/fff/fff-gre/files/etc/gateway.d/50-gre

						
				@ -0,0 +96,4 @@

						babel_add_iifrules "$prefixname" || { echo "ERROR: Could not add iif-rules for gre6eer $name"; exit 1; }

						# add babel interface

						babel_add_interface "$prefixname" "$prefixname" 'tunnel' "$rxcost" || { echo "ERROR: Could not add babeld interface for gre6eer $name"; exit 1; }