fff-network: fix code flow for one-port devices in configurenetwork #104

adschm · 2021-02-09T23:33:17+01:00

adschm commented

2021-02-09 23:33:17 +01:00

So far, all one-port devices also triggered the switch-based setup
in configurenetwork, as the one-port condition was not checked
there. While the relevant parts are overwritten by the one-port
config which comes later in the script, it still creates a lot
of useless/broken switch/vlan setup entries in /etc/config/network.

Properly check for one-port vs. non-one-port in the file, without
touching anything else.

Das sieht schlimm aus, ist aber im Prinzip nicht viel Änderungen, der Code wird nur hin- und hergeschoben.

So far, all one-port devices also triggered the switch-based setup in configurenetwork, as the one-port condition was not checked there. While the relevant parts are overwritten by the one-port config which comes later in the script, it still creates a lot of useless/broken switch/vlan setup entries in /etc/config/network. Properly check for one-port vs. non-one-port in the file, without touching anything else. --- Das sieht schlimm aus, ist aber im Prinzip nicht viel Änderungen, der Code wird nur hin- und hergeschoben.

adschm added the

bug

packages/fff

labels 2021-02-09 23:33:17 +01:00

adschm added 1 commit 2021-02-09 23:33:18 +01:00

9a1946d157 fff-network: fix code flow for one-port devices in configurenetwork

So far, all one-port devices also triggered the switch-based setup
in configurenetwork, as the one-port condition was not checked
there. While the relevant parts are overwritten by the one-port
config which comes later in the script, it still creates a lot
of useless/broken switch/vlan setup entries in /etc/config/network.

Properly check for one-port vs. non-one-port in the file, without
touching anything else.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>

fbl approved these changes 2021-03-02 01:23:18 +01:00

fbl left a comment

Acked-by: Fabian Bläse <fabian@blaese.de>

`Acked-by: Fabian Bläse <fabian@blaese.de>`

adschm referenced this pull request

2021-06-09 12:48:02 +02:00

fff-network: fix support for CPE and provide two-port support #143

adschm closed this pull request

2021-07-10 19:27:35 +02:00