buildscript: fix/improve prepare step #103

Closed
adschm wants to merge 3 commits from adschm:buildscript into master
Owner

This addresses several buildscript issues:

  • remove obsolete link for common download dir
  • remove template replacement for root_file_system
  • don't wipe build directory on prepare
This addresses several buildscript issues: * remove obsolete link for common download dir * remove template replacement for root_file_system * don't wipe build directory on prepare
adschm added the
build/scripts/tools
label 2021-02-04 15:41:18 +01:00
adschm added 3 commits 2021-02-04 15:41:19 +01:00
8aad142794 buildscript: remove unneeded global download directory link
Some time ago, the firmware created a directory for each target
and built OpenWrt separately there. In this situation, it made
sense to download files only once and share them between these
build directories.

However, since we nowadays only have one build directory for all
targets, this makes no sense anymore. Remove the link.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
2d8334e2df buildscript: do not overwrite build directory on prepare
So far, we remove the old and copy a fresh new OpenWrt directory
into the build directory on prepare. There is no need to do this,
as OpenWrt/Make is capable of detecting changes and we do properly
update the feeds and patches already.

So, just clone the OpenWrt main repo into builddir directly, and
just checkout/apply patches during prepare.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
2c807356ea buildscript: remove obsolete template rewrite
We do not use any *.tpl files anymore, so remove the routine for
installing them.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
rohammer approved these changes 2021-02-08 19:04:04 +01:00
rohammer left a comment
Member

Aufraeumen tut immer gut.

Reviewed-by: Robert Langhammer <rlanghammer@web.de>
Aufraeumen tut immer gut. ``` Reviewed-by: Robert Langhammer <rlanghammer@web.de> ```
Author
Owner

Ich nehme mal den einfachen ersten Patch und lasse den Rest noch etwas liegen.

Ich nehme mal den einfachen ersten Patch und lasse den Rest noch etwas liegen.
fbl approved these changes 2021-03-02 00:51:41 +01:00
fbl left a comment
Owner

Sowohl mit als auch ohne der angefragten Änderung:
Reviewed-by: Fabian Bläse <fabian@blaese.de>

Sowohl mit als auch ohne der angefragten Änderung: `Reviewed-by: Fabian Bläse <fabian@blaese.de>`
@ -63,2 +63,4 @@
if $MYGIT remote -v | grep -q "$REPO_URL" ; then
echo "Right remote detected"
# Reset tracked files
$MYGIT reset --hard HEAD
Owner

Ich würde hier "$COMMITID" nehmen.
Aber das brauchts hier gar nicht, wenn man beim checkout noch ein "-f" hinzufügt. Würde ich glaube ich bevorzugen.

Ich würde hier "$COMMITID" nehmen. Aber das brauchts hier gar nicht, wenn man beim checkout noch ein "-f" hinzufügt. Würde ich glaube ich bevorzugen.
Author
Owner

Merged to my staging tree with the "checkout -f" change.

Merged to my staging tree with the "checkout -f" change.
adschm closed this pull request 2021-03-06 18:42:13 +01:00

Pull request closed

Sign in to join this conversation.
No description provided.