freifunk-franken
/
firmware
9
7
Fork 13
Code Issues 48 Pull Requests 7 Releases 17 Wiki Activity

fff-dhcp: fix indexing and output in uci-defaults #100

Closed
adschm wants to merge 1 commits from adschm:dhcpconf into master
pull from: adschm:dhcpconf
merge into: freifunk-franken:master
Conversation 1 Commits 1 Files Changed 2 +22 -22
adschm commented 2021-01-31 14:04:16 +01:00
Owner
Copy Link

When creating a new uci section, the safest way to refer to it is
with index '-1'. While it (probably) does not make a functional
difference for our specific case, since we expect to only have one
section anyway, let's just make sure and use the proper indexing.

While at it, suppress output from the 'add' command.

Signed-off-by: Adrian Schmutzler freifunk@adrianschmutzler.de

When creating a new uci section, the safest way to refer to it is with index '-1'. While it (probably) does not make a functional difference for our specific case, since we expect to only have one section anyway, let's just make sure and use the proper indexing. While at it, suppress output from the 'add' command. Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
adschm added the
layer3
packages/fff
trivial
 labels 2021-01-31 14:04:16 +01:00
adschm added 1 commit 2021-01-31 14:04:16 +01:00
e07402f447 fff-dhcp: fix indexing and output in uci-defaults 
When creating a new uci section, the safest way to refer to it is
with index '-1'. While it (probably) does not make a functional
difference for our specific case, since we expect to only have one
section anyway, let's just make sure and use the proper indexing.

While at it, suppress output from the 'add' command.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
rohammer approved these changes 2021-02-08 19:07:12 +01:00
rohammer left a comment
Member
Copy Link

ja, gibt nicht viel mehr dazu zu sagen:

Reviewed-by: Robert Langhammer <rlanghammer@web.de>
ja, gibt nicht viel mehr dazu zu sagen: ``` Reviewed-by: Robert Langhammer <rlanghammer@web.de> ```
adschm commented 2021-02-09 22:59:50 +01:00
Author
Owner
Copy Link

Wird gemergt.

Wird gemergt.
adschm closed this pull request 2021-02-09 22:59:50 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
rohammer
Labels
Clear labels   
RFC

   
RFT

   
WIP

   
blocked

   
bsp

touching bsp files or adding devices

  
bug

Something is not working

  
build/scripts/tools

touching buildscript or other tools

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
fixed

Issue that got resolved

  
layer3

only for layer3 FW

  
mantis

Imported from mantis

  
more details required

Reported information is insufficient to debug the issue

  
needs changes

   
node

only for node FW

  
packages/fff

touching our packages

  
rejected

Rejected or won't fix

  
security

   
trivial

simple non-functional changes that are mostly matter of taste

  
upstream

touching upstream version, build or feed patches

No Label
RFC
RFT
WIP
blocked
bsp
bug
build/scripts/tools
duplicate
feature
fixed
layer3
mantis
more details required
needs changes
node
packages/fff
rejected
security
trivial
upstream
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: freifunk-franken/firmware#100
No description provided.
Delete Branch "adschm:dhcpconf"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?