26 lines
853 B
Diff
26 lines
853 B
Diff
From: Yang Yingliang <yangyingliang@huawei.com>
|
|
Date: Fri, 8 Apr 2022 11:22:46 +0800
|
|
Subject: [PATCH] net: ethernet: mtk_eth_soc: fix return value check in
|
|
mtk_wed_add_hw()
|
|
|
|
If syscon_regmap_lookup_by_phandle() fails, it never return NULL pointer,
|
|
change the check to IS_ERR().
|
|
|
|
Fixes: 804775dfc288 ("net: ethernet: mtk_eth_soc: add support for Wireless Ethernet Dispatch (WED)")
|
|
Reported-by: Hulk Robot <hulkci@huawei.com>
|
|
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
---
|
|
|
|
--- a/drivers/net/ethernet/mediatek/mtk_wed.c
|
|
+++ b/drivers/net/ethernet/mediatek/mtk_wed.c
|
|
@@ -816,7 +816,7 @@ void mtk_wed_add_hw(struct device_node *
|
|
return;
|
|
|
|
regs = syscon_regmap_lookup_by_phandle(np, NULL);
|
|
- if (!regs)
|
|
+ if (IS_ERR(regs))
|
|
return;
|
|
|
|
rcu_assign_pointer(mtk_soc_wed_ops, &wed_ops);
|