mirror of
https://git.openwrt.org/openwrt/openwrt.git
synced 2024-06-14 03:03:52 +02:00
bf991fa357
Backport 5 pending patches [1] for Armada 3720 comphy driver and one patch for device tree, applied to mvebu-dt64, but pending to appear in Linus' tree [2]. These patches makes the driver work correctly even with older, buggy versions of TF-A firmware. [1] http://lists.infradead.org/pipermail/linux-phy/2022-January/002598.html [2] http://lists.infradead.org/pipermail/linux-phy/2021-December/002279.html Signed-off-by: Marek Behún <kabel@kernel.org>
71 lines
2.5 KiB
Diff
71 lines
2.5 KiB
Diff
From 750bb44dbbe9dfb4ba3e1f8a746b831b39ba3cd9 Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali@kernel.org>
|
|
Date: Thu, 23 Sep 2021 19:35:57 +0200
|
|
Subject: [PATCH] Revert "ata: ahci: mvebu: Make SATA PHY optional for Armada
|
|
3720"
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
This reverts commit 45aefe3d2251e4e229d7662052739f96ad1d08d9.
|
|
|
|
Armada 3720 PHY driver (phy-mvebu-a3700-comphy.c) does not return
|
|
-EOPNOTSUPP from phy_power_on() callback anymore.
|
|
|
|
So remove AHCI_HFLAG_IGN_NOTSUPP_POWER_ON flag from Armada 3720 plat data.
|
|
|
|
AHCI_HFLAG_IGN_NOTSUPP_POWER_ON is not used by any other ahci driver, so
|
|
remove this flag completely.
|
|
|
|
Signed-off-by: Pali Rohár <pali@kernel.org>
|
|
Signed-off-by: Marek Behún <kabel@kernel.org>
|
|
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
|
|
---
|
|
drivers/ata/ahci.h | 2 --
|
|
drivers/ata/ahci_mvebu.c | 2 +-
|
|
drivers/ata/libahci_platform.c | 2 +-
|
|
3 files changed, 2 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
|
|
index d1f284f0c83d..3a3e67350e50 100644
|
|
--- a/drivers/ata/ahci.h
|
|
+++ b/drivers/ata/ahci.h
|
|
@@ -240,8 +240,6 @@ enum {
|
|
as default lpm_policy */
|
|
AHCI_HFLAG_SUSPEND_PHYS = (1 << 26), /* handle PHYs during
|
|
suspend/resume */
|
|
- AHCI_HFLAG_IGN_NOTSUPP_POWER_ON = (1 << 27), /* ignore -EOPNOTSUPP
|
|
- from phy_power_on() */
|
|
AHCI_HFLAG_NO_SXS = (1 << 28), /* SXS not supported */
|
|
|
|
/* ap->flags bits */
|
|
diff --git a/drivers/ata/ahci_mvebu.c b/drivers/ata/ahci_mvebu.c
|
|
index 3ad46d26d9d5..d4bba3ace45d 100644
|
|
--- a/drivers/ata/ahci_mvebu.c
|
|
+++ b/drivers/ata/ahci_mvebu.c
|
|
@@ -227,7 +227,7 @@ static const struct ahci_mvebu_plat_data ahci_mvebu_armada_380_plat_data = {
|
|
|
|
static const struct ahci_mvebu_plat_data ahci_mvebu_armada_3700_plat_data = {
|
|
.plat_config = ahci_mvebu_armada_3700_config,
|
|
- .flags = AHCI_HFLAG_SUSPEND_PHYS | AHCI_HFLAG_IGN_NOTSUPP_POWER_ON,
|
|
+ .flags = AHCI_HFLAG_SUSPEND_PHYS,
|
|
};
|
|
|
|
static const struct of_device_id ahci_mvebu_of_match[] = {
|
|
diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
|
|
index 0910441321f7..250b82e30aa3 100644
|
|
--- a/drivers/ata/libahci_platform.c
|
|
+++ b/drivers/ata/libahci_platform.c
|
|
@@ -59,7 +59,7 @@ int ahci_platform_enable_phys(struct ahci_host_priv *hpriv)
|
|
}
|
|
|
|
rc = phy_power_on(hpriv->phys[i]);
|
|
- if (rc && !(rc == -EOPNOTSUPP && (hpriv->flags & AHCI_HFLAG_IGN_NOTSUPP_POWER_ON))) {
|
|
+ if (rc) {
|
|
phy_exit(hpriv->phys[i]);
|
|
goto disable_phys;
|
|
}
|
|
--
|
|
2.34.1
|
|
|