70 lines
2.4 KiB
Diff
70 lines
2.4 KiB
Diff
From c91377495192cda096e52dc09c266b0d05f16d86 Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
|
Date: Thu, 21 Feb 2019 11:33:25 +0100
|
|
Subject: [PATCH] brcmfmac: print firmware reported general status errors
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Firmware may report general errors using a special message type. Add
|
|
basic support for it by simply decoding & printing an error number.
|
|
|
|
A sample situation in which firmware reports a buf error:
|
|
CONSOLE: 027084.733 no host response IOCTL buffer available..so fail the request
|
|
will now produce a "Firmware reported general error: 9" on the host.
|
|
|
|
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
|
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
|
|
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
|
|
---
|
|
.../broadcom/brcm80211/brcmfmac/msgbuf.c | 24 +++++++++++++++++++
|
|
1 file changed, 24 insertions(+)
|
|
|
|
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
|
|
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
|
|
@@ -134,6 +134,14 @@ struct msgbuf_completion_hdr {
|
|
__le16 flow_ring_id;
|
|
};
|
|
|
|
+/* Data struct for the MSGBUF_TYPE_GEN_STATUS */
|
|
+struct msgbuf_gen_status {
|
|
+ struct msgbuf_common_hdr msg;
|
|
+ struct msgbuf_completion_hdr compl_hdr;
|
|
+ __le16 write_idx;
|
|
+ __le32 rsvd0[3];
|
|
+};
|
|
+
|
|
/* Data struct for the MSGBUF_TYPE_RING_STATUS */
|
|
struct msgbuf_ring_status {
|
|
struct msgbuf_common_hdr msg;
|
|
@@ -1192,6 +1200,18 @@ brcmf_msgbuf_process_rx_complete(struct
|
|
brcmf_netif_rx(ifp, skb);
|
|
}
|
|
|
|
+static void brcmf_msgbuf_process_gen_status(struct brcmf_msgbuf *msgbuf,
|
|
+ void *buf)
|
|
+{
|
|
+ struct msgbuf_gen_status *gen_status = buf;
|
|
+ struct brcmf_pub *drvr = msgbuf->drvr;
|
|
+ int err;
|
|
+
|
|
+ err = le16_to_cpu(gen_status->compl_hdr.status);
|
|
+ if (err)
|
|
+ bphy_err(drvr, "Firmware reported general error: %d\n", err);
|
|
+}
|
|
+
|
|
static void brcmf_msgbuf_process_ring_status(struct brcmf_msgbuf *msgbuf,
|
|
void *buf)
|
|
{
|
|
@@ -1271,6 +1291,10 @@ static void brcmf_msgbuf_process_msgtype
|
|
|
|
msg = (struct msgbuf_common_hdr *)buf;
|
|
switch (msg->msgtype) {
|
|
+ case MSGBUF_TYPE_GEN_STATUS:
|
|
+ brcmf_dbg(MSGBUF, "MSGBUF_TYPE_GEN_STATUS\n");
|
|
+ brcmf_msgbuf_process_gen_status(msgbuf, buf);
|
|
+ break;
|
|
case MSGBUF_TYPE_RING_STATUS:
|
|
brcmf_dbg(MSGBUF, "MSGBUF_TYPE_RING_STATUS\n");
|
|
brcmf_msgbuf_process_ring_status(msgbuf, buf);
|