mirror of
https://git.openwrt.org/openwrt/openwrt.git
synced 2024-06-17 04:33:57 +02:00
680f8738d0
Fixes no communication with tethered iOS devices in CDC NCM mode.
Freshly booted iOS devices start in legacy mode, but are put into
NCM mode by the official Apple driver.
[1] a2d274c62e
Fixes: #12566
Tested-by: Georgi Valkov <gvalkov@gmail.com>
Signed-off-by: Foster Snowhill <forst@pen.gy>
Signed-off-by: Georgi Valkov <gvalkov@gmail.com>
[ better reference fixed issue ]
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
31 lines
1.0 KiB
Diff
31 lines
1.0 KiB
Diff
From 2203718c2f59ffdd6c78d54e5add594aebb4461e Mon Sep 17 00:00:00 2001
|
|
From: Georgi Valkov <gvalkov@gmail.com>
|
|
Date: Wed, 7 Jun 2023 15:56:59 +0200
|
|
Subject: [PATCH 1/4] usbnet: ipheth: fix risk of NULL pointer deallocation
|
|
|
|
The cleanup precedure in ipheth_probe will attempt to free a
|
|
NULL pointer in dev->ctrl_buf if the memory allocation for
|
|
this buffer is not successful. While kfree ignores NULL pointers,
|
|
and the existing code is safe, it is a better design to rearrange
|
|
the goto labels and avoid this.
|
|
|
|
Signed-off-by: Georgi Valkov <gvalkov@gmail.com>
|
|
Signed-off-by: Foster Snowhill <forst@pen.gy>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
---
|
|
drivers/net/usb/ipheth.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
--- a/drivers/net/usb/ipheth.c
|
|
+++ b/drivers/net/usb/ipheth.c
|
|
@@ -510,8 +510,8 @@ err_register_netdev:
|
|
ipheth_free_urbs(dev);
|
|
err_alloc_urbs:
|
|
err_get_macaddr:
|
|
-err_alloc_ctrl_buf:
|
|
kfree(dev->ctrl_buf);
|
|
+err_alloc_ctrl_buf:
|
|
err_endpoints:
|
|
free_netdev(netdev);
|
|
return retval;
|