39 lines
1.4 KiB
Diff
39 lines
1.4 KiB
Diff
From 28de437934da2fb9f04b0c4f5aa73553e63894e3 Mon Sep 17 00:00:00 2001
|
|
From: Maxime Ripard <maxime@cerno.tech>
|
|
Date: Mon, 21 Jun 2021 16:13:02 +0200
|
|
Subject: [PATCH] drm/vc4: crtc: Add some logging
|
|
|
|
The encoder retrieval code has been a source of bugs and glitches in the
|
|
past and the crtc <-> encoder association been wrong in a number of
|
|
different ways.
|
|
|
|
Add some logging to quickly spot issues if they occur.
|
|
|
|
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
|
|
---
|
|
drivers/gpu/drm/vc4/vc4_crtc.c | 6 ++++++
|
|
1 file changed, 6 insertions(+)
|
|
|
|
--- a/drivers/gpu/drm/vc4/vc4_crtc.c
|
|
+++ b/drivers/gpu/drm/vc4/vc4_crtc.c
|
|
@@ -545,6 +545,9 @@ static void vc4_crtc_atomic_disable(stru
|
|
struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, old_state);
|
|
struct drm_device *dev = crtc->dev;
|
|
|
|
+ drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)",
|
|
+ crtc->name, crtc->base.id, encoder->name, encoder->base.id);
|
|
+
|
|
require_hvs_enabled(dev);
|
|
|
|
/* Disable vblank irq handling before crtc is disabled. */
|
|
@@ -576,6 +579,9 @@ static void vc4_crtc_atomic_enable(struc
|
|
struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, new_state);
|
|
struct vc4_encoder *vc4_encoder = to_vc4_encoder(encoder);
|
|
|
|
+ drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)",
|
|
+ crtc->name, crtc->base.id, encoder->name, encoder->base.id);
|
|
+
|
|
require_hvs_enabled(dev);
|
|
|
|
/* Enable vblank irq handling before crtc is started otherwise
|