Tony Ambardar 484117b478 base-files: fix postinstall uci-defaults removal ... Commit 7f694582 introduced a bug where default_postinst() often fails to remove a uci-defaults script after application, leaving it to run again after a reboot. (Note: commit 7f694582 also introduced FS#1021, now fixed by 73c745f6) The subtle problem arises from the shell logical chain: [ -f "$i" ] && . "$i" && rm -f "$i" Most uci-defaults scripts contain a terminal 'exit 0' statement which, when sourced, results in the logic chain exiting before executing 'rm -f'. This was observed while testing upgrades of 'luci-app-sqm'. The solution is to wrap the shell sourcing in a subshell relative to the command 'rm -f': ( [ -f "$i" ] && . "$i" ) && rm -f "$i" Revert to using 'grep' to prefilter the list of entries from the control file, which yields the full path of uci-defaults scripts. This allows keeping the existence check, directory change and script sourcing inside the subshell, with the script removal correctly outside. This approach avoids adding a second subshell only around the "." (source) command. The change also preserves the fix FS#1021, since the full path is used to source the script, which is POSIX-portable irrespective of PATH variable or reference to the CWD. Run Tested on: LEDE 17.01.4 running ar71xx, while tracing installation of package luci-app-sqm with its associated /etc/uci-defaults/luci-sqm file. Signed-off-by: Tony Ambardar <itugrok@yahoo.com> (backported from 4097ab6a97)		2019-01-22 07:22:59 +01:00
..
bin	base-files: fix wan6 interface config generation for pppoe	2017-09-18 13:22:58 +02:00
etc	base-files: fix unkillable processes after restart	2018-11-22 13:56:37 +01:00
lib	base-files: fix postinstall uci-defaults removal	2019-01-22 07:22:59 +01:00
rom	rename default/ to files/	2006-11-22 23:30:57 +00:00
sbin	base-files: sysupgrade: do not rely on opkg to list changed conffiles	2018-03-07 10:01:14 +01:00
usr	base-files: suppress uci not found output in login.sh	2017-12-13 16:23:39 +01:00