33 lines
1.2 KiB
Diff
33 lines
1.2 KiB
Diff
From 3bdae810721b33061d2e541bd78a70f86ca42af3 Mon Sep 17 00:00:00 2001
|
|
From: Florian Fainelli <f.fainelli@gmail.com>
|
|
Date: Mon, 18 Jul 2016 16:24:34 -0700
|
|
Subject: [PATCH] brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain
|
|
|
|
In case brcmf_sdiod_recv_chain() cannot complete a succeful call to
|
|
brcmf_sdiod_buffrw, we would be leaking glom_skb and not free it as we
|
|
should, fix this.
|
|
|
|
Reported-by: coverity (CID 1164856)
|
|
Fixes: a413e39a38573 ("brcmfmac: fix brcmf_sdcard_recv_chain() for host without sg support")
|
|
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
|
|
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
|
|
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
|
|
---
|
|
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 4 +++-
|
|
1 file changed, 3 insertions(+), 1 deletion(-)
|
|
|
|
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
|
|
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
|
|
@@ -726,8 +726,10 @@ int brcmf_sdiod_recv_chain(struct brcmf_
|
|
return -ENOMEM;
|
|
err = brcmf_sdiod_buffrw(sdiodev, SDIO_FUNC_2, false, addr,
|
|
glom_skb);
|
|
- if (err)
|
|
+ if (err) {
|
|
+ brcmu_pkt_buf_free_skb(glom_skb);
|
|
goto done;
|
|
+ }
|
|
|
|
skb_queue_walk(pktq, skb) {
|
|
memcpy(skb->data, glom_skb->data, skb->len);
|