59 lines
1.8 KiB
Diff
59 lines
1.8 KiB
Diff
From 959f4ac4940bebb84bdd25ac61470b3965e1e475 Mon Sep 17 00:00:00 2001
|
||
From: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= <arinc.unal@arinc9.com>
|
||
Date: Tue, 6 Feb 2024 01:08:02 +0300
|
||
Subject: [PATCH 30/48] net: dsa: mt7530: empty default case on
|
||
mt7530_setup_port5()
|
||
MIME-Version: 1.0
|
||
Content-Type: text/plain; charset=UTF-8
|
||
Content-Transfer-Encoding: 8bit
|
||
|
||
There're two code paths for setting up port 5:
|
||
|
||
mt7530_setup()
|
||
-> mt7530_setup_port5()
|
||
|
||
mt753x_phylink_mac_config()
|
||
-> mt753x_mac_config()
|
||
-> mt7530_mac_config()
|
||
-> mt7530_setup_port5()
|
||
|
||
On the first code path, priv->p5_intf_sel is either set to
|
||
P5_INTF_SEL_PHY_P0 or P5_INTF_SEL_PHY_P4 when mt7530_setup_port5() is run.
|
||
|
||
On the second code path, priv->p5_intf_sel is set to P5_INTF_SEL_GMAC5 when
|
||
mt7530_setup_port5() is run.
|
||
|
||
Empty the default case which will never run but is needed nonetheless to
|
||
handle all the remaining enumeration values.
|
||
|
||
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
|
||
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
|
||
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
|
||
Link: https://lore.kernel.org/r/20240206-for-netnext-mt7530-improvements-2-v5-1-d7d92a185cb1@arinc9.com
|
||
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
||
---
|
||
drivers/net/dsa/mt7530.c | 5 +----
|
||
1 file changed, 1 insertion(+), 4 deletions(-)
|
||
|
||
--- a/drivers/net/dsa/mt7530.c
|
||
+++ b/drivers/net/dsa/mt7530.c
|
||
@@ -936,9 +936,7 @@ static void mt7530_setup_port5(struct ds
|
||
val &= ~MHWTRAP_P5_DIS;
|
||
break;
|
||
default:
|
||
- dev_err(ds->dev, "Unsupported p5_intf_sel %d\n",
|
||
- priv->p5_intf_sel);
|
||
- goto unlock_exit;
|
||
+ break;
|
||
}
|
||
|
||
/* Setup RGMII settings */
|
||
@@ -968,7 +966,6 @@ static void mt7530_setup_port5(struct ds
|
||
dev_dbg(ds->dev, "Setup P5, HWTRAP=0x%x, intf_sel=%s, phy-mode=%s\n",
|
||
val, p5_intf_modes(priv->p5_intf_sel), phy_modes(interface));
|
||
|
||
-unlock_exit:
|
||
mutex_unlock(&priv->reg_mutex);
|
||
}
|
||
|