Commit Graph

69 Commits

Author SHA1 Message Date
Daniel Golle 13516fa188
transmission: add two more syscalls to seccomp filter
Testing showed that additional syscalls are needed on ARMv7.
Add "clock_gettime64" and "statx" which seem to be used now instead
of "clock_gettime" and "stat" syscalls which are already listed.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2021-09-25 08:27:08 +01:00
Daniel Golle 847b17651a
transmission: add mount trigger
Restart transmission once an underlaying mountpoint becomes available.
Add myself as maintainer.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2021-08-08 15:49:26 +01:00
Rui Salvaterra 2c90c305a6 transmission: apply DSCP to UDP sockets too
Backport a pending patch in order to DSCP-mark UDP traffic. This allows for
correct binning of traffic in diffserv-capable routers.

Additionally, remove Rosen Penev from the maintainers list, as per his request.

Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
2021-08-01 23:14:07 +01:00
Daniel Golle a78e527012
transmission: bump PKG_RELEASE
The commit updating the seccomp filter didn't bump PKG_RELEASE.
Do that now.

Fixes: 1141ee1e5 ("transmission: add new syscalls to seccomp filter)"
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2021-07-10 22:53:26 +01:00
Daniel Golle 1141ee1e51
transmission: add new syscalls to seccomp filter
Testing showed that additional syscalls are needed on ARMv7.
Add "getegid32", "geteuid32", "getgid32" and "getrandom" as they are
all innocent.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2021-07-10 22:04:50 +01:00
Daniel Golle 9ea8cccd35 transmission: add syscalls needed on PPC to seccomp rules
Add fadvise64_64 and fchmod syscalls needed on PowerPC platforms to
seccomp rules of transmission-daemon.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2021-01-06 22:17:40 +00:00
Rosen Penev 044b05fc04
transmission: do not use wolfSSL
There's some kind of crash internally in wolfSSL. It doesn't seem like
anyone knows how to fix it. Just disable it for now.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-12-31 18:05:03 -08:00
Daniel Golle 20c52fc651 transmission: jail: add allow 'getuid' syscall
transmission needs 'getuid', at least on mips_24kc.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2020-12-20 19:09:43 +00:00
Daniel Golle 6b2ec8bcb5
transmission: convert seccomp filter rules to OCI format
procd-seccomp switched to OCI-compliant seccomp parser instead of our
(legacy, OpenWrt-specific) format. Convert ruleset to new format.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2020-11-17 13:16:17 +00:00
Rosen Penev 56e4edad82 transmission: remove variants and use libcurl's TLS library
Allows the Makefile to be cleaned up and to have fewer dependencies.
There's no need for multiple TLS libraries to be installed.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-10-26 21:45:32 -07:00
Rosen Penev 27ba7533e1
transmission: fix mbedtls search
mbedcrypto should be searched, not mbedtls. Also, there is no pkgconfig
file with mbedtls. Fixed that as well. Removed Makefile hacks.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-10-13 21:07:46 -07:00
Rosen Penev d5818c8a81
transmission: fix compilation with full NLS
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-09-29 14:17:12 -07:00
Josef Zila 9a82c952b4 transmission: add access to web interface files to procd jail
Signed-off-by: Josef Zila <josefzila@gmail.com>
2020-06-18 13:48:07 +02:00
Rosen Penev 89fc95c4fc
transmission: add a disabled notification
Helps to see that transmission must be enabled.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-06-15 19:44:15 -07:00
Jan Pavlinec a6bffd306f
transmission: init script check syscall list for seccomp
Signed-off-by: Jan Pavlinec <jan.pavlinec@nic.cz>
2020-05-26 14:16:40 +02:00
Rosen Penev 93485dd317
transmission: update to 3.0
remove upstreamed patches. Refresh remaining one.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-05-24 21:20:36 -07:00
Francesco G 4fcc44bc89 transmission: add init file STOP directive
Transmission should stop early on system shutdown to avoid
for example fstab unmount disks when transmission is writing.

Signed-off-by: Francesco G <gfrancesco@users.noreply.github.com>
2020-04-07 12:44:23 +02:00
Daniel Golle 5eccf7e582 Revert "transmission: mount /etc/resolv.conf in jail"
This reverts commit 9778e2f66f.
/etc/resolv.conf is now mounted by default by procd/ujail.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2020-03-13 20:09:21 +01:00
Daniel Golle 9778e2f66f transmission: mount /etc/resolv.conf in jail
transmission needs to have name resolution to be able to resolve
the trackers' hostnames.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2020-03-12 21:19:05 +01:00
Daniel Golle 3724ed3d68 transmission: add syscalls to seccomp filter
Syscalls observered when running on arm32. Add them to seccomp rule.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2020-03-08 17:43:03 +01:00
Richard Yu c6c8ceb0b4
transmission: add service triggers and bump PKG_RELEASE
Signed-off-by: Richard Yu <yurichard3839@gmail.com>
2020-01-18 20:38:03 +08:00
Richard Yu 53fd02d62c
transmission: update config options
add missing 'peer_id_ttl_hours' and remove 'scrape_paused_torrents'
which is not exist in transmission wiki.

Signed-off-by: Richard Yu <yurichard3839@gmail.com>
2020-01-18 20:36:35 +08:00
Rosen Penev 94d893afce
transmission: Fix message_level setting
--log-error in the init script was overriding it.

Added several optimizations to the init script for speed and correctness.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-01-08 19:27:17 -08:00
Daniel Golle 836127bc24 transmission: fix typo in jail setup
Fixes: 609109fa9 ("transmission: add seccomp filter and improve jail")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2020-01-09 02:32:25 +02:00
Daniel Golle 2cce710984 transmission: fix directory creation in init script
Things were done in the wrong order, leading to config_dir not being
chown'ed and subdirectories not being created in case of download_dir
being inside config_dir.

Fixes: 609109fa9 ("transmission: add seccomp filter and improve jail")
Reported-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2020-01-05 11:52:52 +02:00
Daniel Golle 609109fa97 transmission: add seccomp filter and improve jail
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2020-01-04 17:09:21 +02:00
Rosen Penev 6d9ee2ec86
transmission: Disable webseeding
It causes 100% CPU usage in certain situations. Just disable it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2019-11-24 19:01:58 -08:00
Richard Yu 144e7df270
transmission: fix command param issue and use default respawn settings
Signed-off-by: Richard Yu <yurichard3839@gmail.com>
2019-09-27 18:17:02 +08:00
Rosen Penev 6ed8abd958 transmission: Merge all the command line params in one line
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2019-09-26 01:46:26 -07:00
Rosen Penev d6e1e8d9fb
transmission: Fix typo in init script
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2019-09-25 13:25:53 -07:00
Rosen Penev acc646dafb
Merge pull request #9940 from neheb/tr2
transmission: Fix tracker issue with some firewalls
2019-09-23 17:28:10 -07:00
Rosen Penev 730a1697fe transmission: Fix tracker issue with some firewalls
Some firewalls mandate a minimum size of 4k for SYN packets, which
transmission does not do by default. Upstream issue here:

https://github.com/transmission/transmission/issues/964

Cleanup:

Fixed license info.

Removed two unnecessary patches.

Ran shell script through shellcheck.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2019-09-23 11:41:10 -07:00
Jan Pavlinec 299e5b0a9b
treewide: add PKG_CPE_ID for better cvescanner coverage
Signed-off-by: Jan Pavlinec <jan.pavlinec@nic.cz>
2019-09-17 12:40:26 +02:00
Sven Eckelmann bbb1ea7345 treewide: Change .*GPL.*+ licenses to SPDX compatible identifier
The CONTRIBUTING.md requests an (or multiple) SPDX identifier for GPL
licenses. But a lot of packages did use a different, non-SPDX style with a
"+" at the end instead of "-or-later".

Signed-off-by: Sven Eckelmann <sven@narfation.org>
2019-09-10 07:45:15 +02:00
Richard Yu 6b49b9c566
Revert "transmission-web: set conflicts with transmission-web-control"
This reverts commit 18c9a03770.

To fix "make menuconfig" shows "recursive dependency detected".

Signed-off-by: Richard Yu <yurichard3839@gmail.com>
2019-05-07 00:14:28 +08:00
Rosen Penev 7fea6570e5
Merge pull request #8842 from ysc3839/tr-web-control
transmission-web-control: add new package
2019-05-03 09:37:47 -07:00
Rosen Penev f4f665c7db
transmission: Fix compilation under uClibc-ng
Upstream has a patch for this dated 2016.

Also ran the init script through shellcheck.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2019-05-01 10:41:27 -07:00
Richard Yu 18c9a03770
transmission-web: set conflicts with transmission-web-control
Signed-off-by: Richard Yu <yurichard3839@gmail.com>
2019-04-30 02:36:06 +08:00
Richard Yu eaeadff317
transmission: add PKGARCH:=all for transmission-web
Signed-off-by: Richard Yu <yurichard3839@gmail.com>
2019-04-18 16:36:17 +08:00
Rosen Penev 70c34ef472 transmission: Add LTO support to shave off 35KB off of the ipk
Minor Makefile cleanups.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2019-02-15 18:07:31 -08:00
Andrii Korzh 582f697afd transmission: Allow user to configure web ui home directory
Signed-off-by: Andrii Korzh <andrii.korzh@gmail.com>
2018-07-12 15:40:07 +03:00
Rosen Penev a46d0ffb83 transmission: Update to 2.94
Mainly a bugfix for XSS. Patches have been refreshed.

Added an upstream fix for TLS verification. Now enabled by default.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2018-05-27 15:18:12 -07:00
Rosen Penev cfc6d23f9b transmission: Add rpc_host_whitelist support.
It was requested as it can be useful under certain circumstances.

Disabled rpc_whitelist by default. Not only is there a firewall, but it denies access when IP address of the device is changed.

Added group support in UCI. Fixes cases where group does not match the user (nobody:nogroup).

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2018-04-06 13:33:30 -07:00
Rosen Penev abdd061cf4 transmission: Fix HTTPS and mobile devices.
HTTPS verification is totally broken in Transmission. Unclear why. Disabling as a result.

Safari exposes a JavaScript bug that makes it not load. Fixed.

Portcheck was backported to HTTPS for testing initially. Seems like a good idea.

Makefile was also fixed to use the external libnatpmp. Smaller binary.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2018-03-01 22:46:07 -08:00
Rosen Penev ae3e314674 transmission: Restored config_overwrite due to popular demand.
libnatpmp was added as a dependancy to avoid built-in version.

Makefile went through a few adjustments to make it simpler.

CMake support is not happening since Travis is using a broken Ubuntu install.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2018-02-13 11:59:20 -08:00
Rosen Penev e0a5ed9f76 transmission: Fix port test + other fixes.
Ran the transmission init script through shellcheck and fixed errors. Also cleaned up a bit.

Removed ionice support. Will reintroduce if procd adds support.

Removed config_overwrite debugging variable. No need for it.

Enabled TLS verify by default. Added a dependancy to ca-bundle as a result. This is a default in current trunk.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2018-02-01 20:27:07 -08:00
Rosen Penev 1e8905176d transmission: Use external libminiupnpc instead of internal.
The original patch that forced internal usage hid an actual issue in the build system. Replace patch with upstream one.

Also reorganized the Makefile a bit and removed some cruft.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2018-01-28 13:13:40 -08:00
Rosen Penev 1d36e57072 transmission: Update to 2.93 + fixes [v2]
DNS rebinding protection introduced a new option. Use it to disable it as OpenWrt does not need it.

Adjusted Makefile to use the release instead of a git version. Also cleaned up and added LICENSE entries.

Eliminated useless patches. The syslog one actually doesn't log much. No need to mask the os release anymore either.

Added group entry to init script. Otherwise files end up being owned by user:root which is bogus.

v2: Previous maintainer relied on git version of Transmission for mbedtls support. Backport it to the stable instead.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2018-01-28 10:04:19 -08:00
Hannu Nyman 3b3fed7fb8 Revert "transmission: Update to 2.93 + fixes"
This reverts commit 606f615048.

The commit broke the patches:
> Applying ./patches/020-use-internal-miniupnp.patch using plaintext:
> patching file configure.ac
> Hunk #1 succeeded at 378 (offset -8 lines).
>
> Applying ./patches/040-fix-for-mbedtls.patch using plaintext:
> patching file configure.ac
> Hunk #1 FAILED at 154.
> 1 out of 1 hunk FAILED -- saving rejects to file configure.ac.rej
2018-01-28 19:09:38 +02:00
Rosen Penev 606f615048 transmission: Update to 2.93 + fixes
DNS rebinding protection introduced a new option. Use it to disable it as OpenWrt does not need it.

Adjusted Makefile to use the release instead of a git version. Also cleaned up and added LICENSE entries.

Eliminated useless patches. The syslog one actually doesn't log much. No need to mask the os release anymore either.

Added group entry to init script. Otherwise files end up being owned by user:root which is bogus.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2018-01-27 18:26:40 -08:00