mirror
/
openwrt-packages
mirror of https://git.openwrt.org/feed/packages.git
1
0
Fork 0
Code Releases Activity

procps-ng: remove unnecessary PKG_BUILD_DEPENDS 

The package Makefile contains an unnecessary PKG_BUILD_DEPENDS
line that builds gettext and libiconv even in cases where the
build has gettext-full and libiconv-full selected.

This behaviour can and does mask errors in other package Makefiles
that are dependent on libiconv-full if it is compiled before
these packages by causing libiconv-stub to be created and put in
the staging tree and potentially linked against by these
dependent packages when they omit to specify an appropriate
PKG_BUILD_DEPENDS line.

procps-ng does not require gettext or libiconv to be built in
order to compile correctly.

Signed-off-by: Ian Cooper <iancooper@hotmail.com>
This commit is contained in:
Ian Cooper 2020-04-29 11:07:36 +01:00
parent 62ef2a8839
commit afd648e680
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
utils/procps-ng/Makefile
View File

@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
PKG_NAME:=procps-ng
PKG_VERSION:=3.3.15
PKG_RELEASE:=4
PKG_RELEASE:=5
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
PKG_SOURCE_URL:=@SF/procps-ng
@ -22,7 +22,6 @@ PKG_LICENSE_FILES:=COPYING COPYING.LIB
PKG_BUILD_PARALLEL:=1
PKG_INSTALL:=1
PKG_FIXUP:=autoreconf
PKG_BUILD_DEPENDS:=gettext libiconv
include $(INCLUDE_DIR)/package.mk