From a7a3615681a7d2f94719ee8585f61ed9318410ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Date: Wed, 25 Jan 2023 12:34:15 +0100 Subject: [PATCH] ksmbd: select ASN1 explicitly to reduce dependencies MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ksmbd requires ASN.1 grammar compiler so it depends on CONFIG_ASN1. It should select kmod-asn1-decoder for above reason. Due to some problems with kmod-asn1-decoder in the past ksmbd was selecting kmod-nf-nathelper-extra instead. That was affecting network performance in kernel as each loaded conntrack module adds some overhead to packets processing. Fix this unwanted side effect by depending on kmod-asn1-decoder directly. Link: http://lists.openwrt.org/pipermail/openwrt-devel/2023-January/040298.html Signed-off-by: Rafał Miłecki --- kernel/ksmbd/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/ksmbd/Makefile b/kernel/ksmbd/Makefile index 11f183d9e0..e7f55c9b63 100644 --- a/kernel/ksmbd/Makefile +++ b/kernel/ksmbd/Makefile @@ -24,6 +24,7 @@ define KernelPackage/fs-ksmbd URL:=https://github.com/cifsd-team/cifsd FILES:=$(PKG_BUILD_DIR)/ksmbd.ko DEPENDS:= \ + +kmod-asn1-decoder \ +kmod-nls-base \ +kmod-nls-utf8 \ +kmod-crypto-md4 \ @@ -37,11 +38,10 @@ define KernelPackage/fs-ksmbd +kmod-crypto-aead \ +kmod-crypto-ccm \ +kmod-crypto-gcm \ - +kmod-fs-nfsd \ - +kmod-nf-nathelper-extra + +kmod-fs-nfsd endef -# The last two DEPENDS are hacks in order to get CONFIG_ASN1 and CONFIG_OID_REGISTRY +# The last DEPENDS entry is a hack in order to get CONFIG_OID_REGISTRY # which it seems can't be selected independently. Some bug in either base or upstream. define KernelPackage/fs-ksmbd/description