named: don't leak mktemp files on reload

Unless we're using "mktemp -u ..." (not recommended), it will
create the temp file as part of its safety checking.  Thus you
should only create the name (file) if you're going to use it,
and always remove it if you have created it.

Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
This commit is contained in:
Philip Prindeville 2022-03-14 19:52:18 -06:00 committed by Rosen Penev
parent 59b89ae066
commit 9e4485b156
1 changed files with 2 additions and 1 deletions

View File

@ -12,7 +12,6 @@ config_dir=$(dirname $config_file)
named_options_file=/etc/bind/named-rndc.conf
rndc_conf_file=/etc/bind/rndc.conf
pid_file=/var/run/named/named.pid
rndc_temp=$(mktemp /tmp/rndc-confgen.XXXXXX)
logdir=/var/log/named/
cachedir=/var/cache/bind
@ -47,6 +46,8 @@ start_service() {
chown bind.bind $runnamed
}
local rndc_temp=$(mktemp /tmp/rndc-confgen.XXXXXX)
rndc-confgen > $rndc_temp
sed -r -n \