From 6020ca52bf5d7b2869ef1ff8a966d15281aa56ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Date: Thu, 11 May 2023 13:27:32 +0200 Subject: [PATCH] wsdd2: fix stopping service MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Function start_service() is called whenever service may need reloading. If SMB server is not running it could be simply because it has been stopped. Reloading service in such case is not an error so: 1. Don't log error as it isn't one 2. Don't exit with error code as it was confusing procd This change fixes scenario like: /etc/init.d/ksmbd stop /etc/init.d/wsdd2 reload (previously above wasn't stopping wsdd2) Signed-off-by: Rafał Miłecki --- net/wsdd2/Makefile | 2 +- net/wsdd2/files/wsdd2.init | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/wsdd2/Makefile b/net/wsdd2/Makefile index 1c5c1bd062..a10a68cac7 100644 --- a/net/wsdd2/Makefile +++ b/net/wsdd2/Makefile @@ -1,7 +1,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=wsdd2 -PKG_RELEASE:=2 +PKG_RELEASE:=3 PKG_SOURCE_PROTO:=git PKG_SOURCE_URL:=https://github.com/Netgear/wsdd2.git diff --git a/net/wsdd2/files/wsdd2.init b/net/wsdd2/files/wsdd2.init index e3df25e2d1..7b8930e06c 100644 --- a/net/wsdd2/files/wsdd2.init +++ b/net/wsdd2/files/wsdd2.init @@ -29,8 +29,8 @@ start_service() { } [ -z "$SMB_CONF" ] && { - logger -p daemon.error -t 'wsdd2' "samba36/4 or ksmbd is not running, can't start wsdd2!" - exit 1 + logger -p daemon.info -t 'wsdd2' "samba36/4 or ksmbd is not running" + return } # cleanup comments