From 4af04cdc05af1e78dab310550fae5bae21d51c8c Mon Sep 17 00:00:00 2001 From: Georgi Valkov Date: Sun, 28 Nov 2021 19:22:56 +0200 Subject: [PATCH] ksmbd-tools: Fix ksmbd service is semi-killed at system startup The configuration for the ksmbd service is auto-generated when the OpenWRT configuration changes, and also during startup, hence ksmbd.init has to reload the kernel module. It does that by calling kill_server, which does not perform cleanup. This results in ksmbd being killed but not restarted properly during boot. This patch resolves the issue by using stop_service, which performs proper cleanup. https://forum.openwrt.org/t/ksmbd-samba3-4-alternative-ex-cifsd-smbd-package-support-thread/51695/68 Signed-off-by: Georgi Valkov --- net/ksmbd-tools/Makefile | 2 +- net/ksmbd-tools/files/ksmbd.init | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ksmbd-tools/Makefile b/net/ksmbd-tools/Makefile index 2b137347b4..ad74c28e0c 100644 --- a/net/ksmbd-tools/Makefile +++ b/net/ksmbd-tools/Makefile @@ -2,7 +2,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=ksmbd-tools PKG_VERSION:=3.4.2 -PKG_RELEASE:=1 +PKG_RELEASE:=$(AUTORELEASE) PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz PKG_SOURCE_URL:=https://codeload.github.com/cifsd-team/ksmbd-tools/tar.gz/$(PKG_VERSION)? diff --git a/net/ksmbd-tools/files/ksmbd.init b/net/ksmbd-tools/files/ksmbd.init index 2c296b10b7..7c628e826d 100644 --- a/net/ksmbd-tools/files/ksmbd.init +++ b/net/ksmbd-tools/files/ksmbd.init @@ -151,7 +151,7 @@ start_service() fi # NOTE: We don't do a soft-reload via signal, since [global] smb.conf setting changes will be ignored, so always reset hard. - kill_server + [ -e /sys/module/ksmbd ] && stop_service [ ! -e /sys/module/ksmbd ] && modprobe ksmbd 2> /dev/null if [ ! -e /sys/module/ksmbd ]; then