From 4618427debdc0e8db1400cb3ee1a67000baff00c Mon Sep 17 00:00:00 2001 From: David Woodhouse Date: Thu, 28 Jun 2018 16:23:24 +0100 Subject: [PATCH] rtl-sdr: fix build when GCC decides not to emit inlines Maybe we should use something other than -Os for this code anyway; it's generally quite CPU-intensive. Signed-off-by: David Woodhouse --- utils/rtl-sdr/Makefile | 2 +- utils/rtl-sdr/patches/101-fix-inlines.patch | 66 +++++++++++++++++++++ 2 files changed, 67 insertions(+), 1 deletion(-) create mode 100644 utils/rtl-sdr/patches/101-fix-inlines.patch diff --git a/utils/rtl-sdr/Makefile b/utils/rtl-sdr/Makefile index 3e375122a9..2732bd4291 100644 --- a/utils/rtl-sdr/Makefile +++ b/utils/rtl-sdr/Makefile @@ -8,7 +8,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=rtl-sdr PKG_VERSION:=0.5.3-20150608-$(PKG_SOURCE_VERSION) -PKG_RELEASE:=2 +PKG_RELEASE:=3 PKG_SOURCE_PROTO:=git PKG_SOURCE_URL:=git://git.osmocom.org/rtl-sdr.git diff --git a/utils/rtl-sdr/patches/101-fix-inlines.patch b/utils/rtl-sdr/patches/101-fix-inlines.patch new file mode 100644 index 0000000000..c30cc8d61c --- /dev/null +++ b/utils/rtl-sdr/patches/101-fix-inlines.patch @@ -0,0 +1,66 @@ +From 6c01778cf7ff81d9a571291fee615b65961ca1d5 Mon Sep 17 00:00:00 2001 +From: David Woodhouse +Date: Thu, 28 Jun 2018 16:21:11 +0100 +Subject: [PATCH] Fix inline functions to use 'static inline' + +With just 'inline', if the compiler decides not to inline them, it isn't +required to emit them at all. For some targets with -Os that is causing +build failures. + +Perhaps we might consider using '__attribute__((always_inline))' for +GCC builds, but 'static inline' is a good start. +--- + src/rtl_adsb.c | 8 ++++---- + src/rtl_power.c | 2 +- + 2 files changed, 5 insertions(+), 5 deletions(-) + +diff --git a/src/rtl_adsb.c b/src/rtl_adsb.c +index 9087de4..7aea8dd 100644 +--- a/src/rtl_adsb.c ++++ b/src/rtl_adsb.c +@@ -183,7 +183,7 @@ int magnitute(uint8_t *buf, int len) + return len/2; + } + +-inline uint16_t single_manchester(uint16_t a, uint16_t b, uint16_t c, uint16_t d) ++static inline uint16_t single_manchester(uint16_t a, uint16_t b, uint16_t c, uint16_t d) + /* takes 4 consecutive real samples, return 0 or 1, BADSAMPLE on error */ + { + int bit, bit_p; +@@ -224,17 +224,17 @@ inline uint16_t single_manchester(uint16_t a, uint16_t b, uint16_t c, uint16_t d + return BADSAMPLE; + } + +-inline uint16_t min16(uint16_t a, uint16_t b) ++static inline uint16_t min16(uint16_t a, uint16_t b) + { + return ab ? a : b; + } + +-inline int preamble(uint16_t *buf, int i) ++static inline int preamble(uint16_t *buf, int i) + /* returns 0/1 for preamble at index i */ + { + int i2; +diff --git a/src/rtl_power.c b/src/rtl_power.c +index 00f4d9f..625d818 100644 +--- a/src/rtl_power.c ++++ b/src/rtl_power.c +@@ -250,7 +250,7 @@ void sine_table(int size) + } + } + +-inline int16_t FIX_MPY(int16_t a, int16_t b) ++static inline int16_t FIX_MPY(int16_t a, int16_t b) + /* fixed point multiply and scale */ + { + int c = ((int)a * (int)b) >> 14; +-- +2.7.4 +