From c9b1b760346e0c90eb702b9119ea1d6915ce39fb Mon Sep 17 00:00:00 2001 From: Tobias Schramm Date: Tue, 20 Feb 2018 12:09:15 +0100 Subject: [PATCH] autoupdater: Fix possible null ptr on signature list Previously reallocation of the signature list could fail silently leading to a null ptr dereference Signed-off-by: Tobias Schramm --- admin/autoupdater/src/manifest.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/admin/autoupdater/src/manifest.c b/admin/autoupdater/src/manifest.c index dbad89e..16fcdc6 100644 --- a/admin/autoupdater/src/manifest.c +++ b/admin/autoupdater/src/manifest.c @@ -89,6 +89,11 @@ void parse_line(char *line, struct manifest *m, const char *branch, const char * } m->n_signatures++; m->signatures = realloc(m->signatures, m->n_signatures * sizeof(ecdsa_signature_t *)); + if (!m->signatures) { + fprintf(stderr, "autoupdater: error: failed to extend signature list\n"); + abort(); + } + m->signatures[m->n_signatures - 1] = sig; } else if (strcmp(line, "---") == 0) { m->sep_found = true;