fff-web-ui: fix port selection for TWO_PORT devices #259

fbl · 2022-07-20T13:44:49+02:00

fbl commented

2022-07-20 13:44:49 +02:00

Support for devices with two ports was originally intended for built-in
swconfig switches with only two externally exposed ethernet ports.

With the switch from ath71xx to ath79, the only device which ever made
use of this uncommon configuration (CPE210-v1) now has to dedicated
interfaces exposed to Linux. Therefore, two-port support was modified to
support two distinct interfaces instead of swconfig switch
configuration, which also simplified support for a few other devices.

However, the Web UI has not been taken into account. Due to the way the
Web UI detected a two-port device, the already implemented port selector
is not shown.

Use the TWO_PORT variable introduced with the change mentioned above to
detect two-port devices instead.

Fixes: #257
Fixes: c22032e254 ("fff-network: support native two-port devices")

Support for devices with two ports was originally intended for built-in swconfig switches with only two externally exposed ethernet ports. With the switch from ath71xx to ath79, the only device which ever made use of this uncommon configuration (CPE210-v1) now has to dedicated interfaces exposed to Linux. Therefore, two-port support was modified to support two distinct interfaces instead of swconfig switch configuration, which also simplified support for a few other devices. However, the Web UI has not been taken into account. Due to the way the Web UI detected a two-port device, the already implemented port selector is not shown. Use the TWO_PORT variable introduced with the change mentioned above to detect two-port devices instead. Fixes: #257 Fixes: c22032e25430 ("fff-network: support native two-port devices")

fbl added this to the next-bugfix milestone 2022-07-20 13:44:49 +02:00

fbl added the

bug

label 2022-07-20 13:44:49 +02:00

fbl added 1 commit 2022-07-20 13:44:50 +02:00

13d775ff2a fff-web-ui: fix port selection for TWO_PORT devices

Support for devices with two ports was originally intended for built-in
swconfig switches with only two externally exposed ethernet ports.

With the switch from ath71xx to ath79, the only device which ever made
use of this uncommon configuration (CPE210-v1) now has to dedicated
interfaces exposed to Linux. Therefore, two-port support was modified to
support two distinct interfaces instead of swconfig switch
configuration, which also simplified support for a few other devices.

However, the Web UI has not been taken into account. Due to the way the
Web UI detected a two-port device, the already implemented port selector
is not shown.

Use the TWO_PORT variable introduced with the change mentioned above to
detect two-port devices instead.

Fixes: #257
Fixes: c22032e254 ("fff-network: support native two-port devices")

Signed-off-by: Fabian Bläse <fabian@blaese.de>

rohammer approved these changes 2022-07-20 17:55:31 +02:00

rohammer left a comment

Reviewed-by: Robert Langhammer rlanghammer@web.de

Reviewed-by: Robert Langhammer <rlanghammer@web.de>

fbl modified the milestone from next-bugfix to 20220814

2022-07-21 19:57:41 +02:00

fbl commented

2022-07-22 14:31:47 +02:00

Applied.

fbl closed this pull request

2022-07-22 14:31:47 +02:00

fbl deleted branch twoport-webui