freifunk-franken
/
firmware
9
7
Fork 13
Code Issues 48 Pull Requests 7 Releases 17 Wiki Activity

fff-ra: Set preferred lifetime smaller than valid lifetime #247

Closed
fbl wants to merge 1 commits from fbl:rafix into master
pull from: fbl:rafix
merge into: freifunk-franken:master
Conversation 2 Commits 1 Files Changed 1 +6
fbl commented 2022-04-10 15:19:10 +02:00
Owner
Copy Link

A recent change (b26399283a) introduced an upper limit for the preferred
and valid lifetimes, so the statically configured addresses on the client
interface do not result in infinite lifetimes.

This upper bound is derived from the dhcp lease time. However, the
preferred lifetime is unexpectedly bound by an explicit configuration
option in recent versions of odhcpd. Due to our short dhcp leasetime,
the default value of this option is higher than the lease time, which
results preferred lifetimes longer than the valid lifetime.

As this behavior is rather unintuitive, a proper fix for it should be
done upstream (see #238). Until then, lower the preferred lifetime
option to the same value as our leasetime.

A recent change (b26399283a) introduced an upper limit for the preferred and valid lifetimes, so the statically configured addresses on the client interface do not result in infinite lifetimes. This upper bound is derived from the dhcp lease time. However, the preferred lifetime is unexpectedly bound by an explicit configuration option in recent versions of odhcpd. Due to our short dhcp leasetime, the default value of this option is higher than the lease time, which results preferred lifetimes longer than the valid lifetime. As this behavior is rather unintuitive, a proper fix for it should be done upstream (see #238). Until then, lower the preferred lifetime option to the same value as our leasetime.
fbl added this to the 20220413 milestone 2022-04-10 15:19:10 +02:00
fbl added the
layer3
 label 2022-04-10 15:19:10 +02:00
fbl force-pushed rafix from 88aec50daa to aad829a96d 2022-04-10 15:20:18 +02:00 Compare
ChristianD commented 2022-04-11 19:12:45 +02:00
Member
Copy Link
Reviewed-by: Christian Dresel <freifunk@dresel.systems>
```` Reviewed-by: Christian Dresel <freifunk@dresel.systems> ````
ChristianD approved these changes 2022-04-11 19:12:50 +02:00
fbl commented 2022-04-13 19:24:01 +02:00
Author
Owner
Copy Link

applied.

applied.
fbl closed this pull request 2022-04-13 19:24:01 +02:00
fbl deleted branch rafix 2022-04-13 19:24:07 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
ChristianD
Labels
Clear labels   
RFC

   
RFT

   
WIP

   
blocked

   
bsp

touching bsp files or adding devices

  
bug

Something is not working

  
build/scripts/tools

touching buildscript or other tools

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
fixed

Issue that got resolved

  
layer3

only for layer3 FW

  
mantis

Imported from mantis

  
more details required

Reported information is insufficient to debug the issue

  
needs changes

   
node

only for node FW

  
packages/fff

touching our packages

  
rejected

Rejected or won't fix

  
security

   
trivial

simple non-functional changes that are mostly matter of taste

  
upstream

touching upstream version, build or feed patches

No Label
RFC
RFT
WIP
blocked
bsp
bug
build/scripts/tools
duplicate
feature
fixed
layer3
mantis
more details required
needs changes
node
packages/fff
rejected
security
trivial
upstream
Milestone
Clear milestone
No items
No Milestone
20220413
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: freifunk-franken/firmware#247
No description provided.
Delete Branch "fbl:rafix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?