fff-network: Do not configure switch for ONE and TWO_PORT devices #225

fbl · 2022-03-24T00:22:34+01:00

fbl commented

2022-03-24 00:22:34 +01:00

In a previous change all static configuration has been moved from
configurenetwork to a static uci-defaults script. As the configuration
of the switch is completely static, while port assignment for ONE and
TWO_PORT devices is dynamic, this patch slightly changed the condition
for the creation of the switch config.

Instead of only configuring the switch, if ONE_PORT and TWO_PORT is not
set, the switch is now always configured if a swconfig device is
present. However, some ONE and TWO_PORT devices have a swconfig device,
even though only a single physical port is connected to it. Those
devices require an unconfigured switch to function properly.

Therefore, introduce additional conditions, so the switch configuration
is not generated if ONE_PORT or TWO_PORT is set.

Fixes: 1c3328e64a ("Remove static configuration from dynamic script")

Signed-off-by: Fabian Bläse fabian@blaese.de

In a previous change all static configuration has been moved from configurenetwork to a static uci-defaults script. As the configuration of the switch is completely static, while port assignment for ONE and TWO_PORT devices is dynamic, this patch slightly changed the condition for the creation of the switch config. Instead of only configuring the switch, if ONE_PORT and TWO_PORT is not set, the switch is now always configured if a swconfig device is present. However, some ONE and TWO_PORT devices have a swconfig device, even though only a single physical port is connected to it. Those devices require an unconfigured switch to function properly. Therefore, introduce additional conditions, so the switch configuration is not generated if ONE_PORT or TWO_PORT is set. Fixes: 1c3328e64ad7 ("Remove static configuration from dynamic script") Signed-off-by: Fabian Bläse <fabian@blaese.de>

fbl added this to the 20220405-beta milestone 2022-03-24 00:22:34 +01:00

fbl added 1 commit 2022-03-24 00:22:34 +01:00

b39ca563d5 fff-network: Do not configure switch for ONE and TWO_PORT devices

In a previous change all static configuration has been moved from
configurenetwork to a static uci-defaults script. As the configuration
of the switch is completely static, while port assignment for ONE and
TWO_PORT devices is dynamic, this patch slightly changed the condition
for the creation of the switch config.

Instead of only configuring the switch, if ONE_PORT and TWO_PORT is not
set, the switch is now always configured if a swconfig device is
present. However, some ONE and TWO_PORT devices have a swconfig device,
even though only a single physical port is connected to it. Those
devices require an unconfigured switch to function properly.

Therefore, introduce additional conditions, so the switch configuration
is not generated if ONE_PORT or TWO_PORT is set.

Fixes: 1c3328e64a ("Remove static configuration from dynamic script")

Signed-off-by: Fabian Bläse <fabian@blaese.de>

fbl referenced this pull request

2022-03-24 00:23:14 +01:00

Convert GL-AR150 to TWO_PORT #224

fbl commented

2022-03-31 14:28:40 +02:00

Plant noch jemand sich das hier anzusehen? Ansonsten werde ich es im laufe des Tage applien.