forked from freifunk-franken/firmware
Fabian Bläse
bdfdbba76a
Many functions of configure-layer3 terminate the program after successful execution, as they were originally only intended for execution of configure-layer3 commands. However, some functions are used both for command exection, but also as helper functions. For example, revert_changes() is used as a helper function in test_changes(). Terminating the program at the end of the function therefore ends the exection of test_changes() prematurely. As a result, the test mode of configure-layer3 never reloads services after a successful configuration revert. Replace exit commands with appropriate function return values, which can then be evaluated by the caller where appropriate. While at it, add a missing return to the parameter validation in execute_subshell(). Fixes: #256 Signed-off-by: Fabian Bläse <fabian@blaese.de> Reviewed-by: Robert Langhammer <rlanghammer@web.de> |
||
|---|---|---|
| .. | ||
| alfred-json | ||
| fff-alfred | ||
| fff-alfred-monitoring-proxy | ||
| fff-babel | ||
| fff-babel-bird2 | ||
| fff-babeld | ||
| fff-base | ||
| fff-batman-adv | ||
| fff-boardname | ||
| fff-config | ||
| fff-dhcp | ||
| fff-fastd | ||
| fff-firewall | ||
| fff-hoods | ||
| fff-hoodutils | ||
| fff-layer3 | ||
| fff-layer3-config | ||
| fff-layer3-snat | ||
| fff-macnock | ||
| fff-mqtt | ||
| fff-mqtt-monitoring | ||
| fff-network | ||
| fff-node | ||
| fff-nodewatcher | ||
| fff-ra | ||
| fff-random | ||
| fff-simple-tc | ||
| fff-support | ||
| fff-sysupgrade | ||
| fff-timeserver | ||
| fff-uradvd | ||
| fff-vpn-select | ||
| fff-vxlan-node-vpn | ||
| fff-web-hood | ||
| fff-web-mqtt | ||
| fff-web-ui | ||
| fff-wireguard | ||
| fff-wireless | ||