forked from freifunk-franken/firmware
Tim Niemeyer
b6c7acd704
This splits up the data extraction/assembly of the nodewatcher script into several parts and distributes them across packages, so that each nodewatcher.d subscript is located in the package providing the relevant functionality. This allows to extend the nodewatcher data by enabling/disabling packages. This scheme is not perfectly fulfilled for fff-network vs. fff-wireless, as data cannot uniquely assigned there and the XML syntax does not allow separation anyway. In general, this moves code without applying code improvements, yielding at an easy comparison of moved fragments. However, the following changes were done to improve experience: - The function writing debug output has been renamed from "err" to "debug" - Since we catch the stdout of the nodewatcher.d functions anyway, those scripts were adjusted to echo output directly instead of first writing it into a variable and then outputting it at the end. - The uci config has been kept, but initialization for the network part has been moved to the fff-network package. - Space indent has been changed to tab, which is more common in the firmware and requires less space. - Remove support for nodewatcher run without uci config. Script-based nodewatcher on other platforms will have altered code anyway, and splitting it up will prevent effective use as a blueprint for those cases. After this change, nodewatcher in firmware is supposed to be used only for this firmware. Note that since the nodewatcher.d scripts are evaluated by using their echo output, having a function created uncaught output to stdout there will corrupt the XML. Signed-off-by: Tim Niemeyer <tim@tn-x.org> [rebase and adjustments for current master, use simpler mechanism to call nodewatcher.d scripts, use tab indent, remove debug() definition where not needed, do not remove uci config, add commit message, use echo -n] Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> Reviewed-by: Fabian Bläse <fabian@blaese.de> [remove 'local' modifier for variable not inside a function, fix typo] Signed-off-by: Fabian Bläse <fabian@blaese.de> |
||
|---|---|---|
| .. | ||
| alfred-json | ||
| fff | ||
| fff-alfred | ||
| fff-alfred-monitoring-proxy | ||
| fff-babeld | ||
| fff-batman-adv | ||
| fff-boardname | ||
| fff-config | ||
| fff-dhcp | ||
| fff-fastd | ||
| fff-firewall | ||
| fff-gateway | ||
| fff-hoods | ||
| fff-hoodutils | ||
| fff-macnock | ||
| fff-network | ||
| fff-node | ||
| fff-nodewatcher | ||
| fff-ra | ||
| fff-random | ||
| fff-simple-tc | ||
| fff-support | ||
| fff-sysupgrade | ||
| fff-timeserver | ||
| fff-uradvd | ||
| fff-vpn-select | ||
| fff-web | ||
| fff-wireguard | ||
| fff-wireless | ||